Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runtime error on saving post in editorial workflow #507

Merged
merged 1 commit into from Aug 17, 2017

Conversation

Benaiah
Copy link
Contributor

@Benaiah Benaiah commented Aug 2, 2017

- Summary

Fixes an error that was showing up in the console when saving a post in the editorial workflow.

The removed dispatch(closeEntry) is handled in the code that's been erroring out (in EntryPage.js). User-visible functionality is identical.

- Test plan

Tested manually. The error only ocurred in one scenario, and is no longer reproducible.

- Description for the changelog

Fixes an error that was showing up in the console when saving a post in the editorial workflow.

The removed `dispatch(closeEntry)` is handled in the code that's been
erroring out (located in `containers/EntryPage.js`). User-visible
functionality is identical.
Copy link
Contributor

@erquhart erquhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erquhart erquhart merged commit 14be00b into master Aug 17, 2017
@tech4him1 tech4him1 deleted the fix-post-save-error branch August 26, 2017 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants