only rebase EW PR if no asset store #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Editorial workflow pull requests are rebased if the base has changed to ensure that asset changes on the base branch are reflected in the PR branch, but if an asset store is in use, no rebasing is necessary because assets are stored outside of the content repo.
erquhart
commented
Nov 11, 2017
| if (options.hasAssetStore) { | ||
| return this.storeMetadata(contentKey, updatedMetadata) | ||
| .then(() => this.patchBranch(branchName, newHead.sha)); | ||
| } |
There was a problem hiding this comment.
This was the original behavior prior to the media library PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Editorial workflow pull requests are rebased if the base has
changed to ensure that asset changes on the base branch are
reflected in the PR branch, but if an asset store is in use,
no rebasing is necessary because assets are stored outside
of the content repo.