Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): update release process #53

Merged
merged 2 commits into from
Feb 14, 2021
Merged

fix(docs): update release process #53

merged 2 commits into from
Feb 14, 2021

Conversation

erezrokah
Copy link
Contributor

Add prerequisites to the release process docs

@erezrokah erezrokah added the type: bug code to address defects in shipped code label Feb 11, 2021
keiko713
keiko713 approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@keiko713 keiko713 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving by assuming that this is the step you had to take this time

@erezrokah
Copy link
Contributor Author

approving by assuming that this is the step you had to take this time

Yes - had to look into older versions of nfpm since we use some deprecated options

netlify-credential-helper/resources/nfpm.yaml

Line 18 in 961f8a9

bindir: "/usr/local/bin"

@erezrokah erezrokah merged commit 763b504 into master Feb 14, 2021
@erezrokah erezrokah deleted the docs/update_release_process branch February 14, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keiko713 keiko713 keiko713 approved these changes

Assignees
No one assigned
Labels
type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erezrokah @keiko713