Skip to content
This repository has been archived by the owner on May 2, 2022. It is now read-only.

fix(deps): remove the unneeded @types/node dependency #842

Merged
merged 1 commit into from
Jan 13, 2022
Merged

fix(deps): remove the unneeded @types/node dependency #842

merged 1 commit into from
Jan 13, 2022

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Jan 13, 2022

IIRC this is unused. Would be nice if someone checked your other packages for such cases later :)

PS. Unfortunately, it doesn't save us anything because it's a transitional dependency too.

🎉 Thanks for sending this pull request! 🎉

Please make sure the title is clear and descriptive.

If you are fixing a typo or documentation, please skip these instructions.

Otherwise please fill in the sections below.

Which problem is this pull request solving?

Example: I'm always frustrated when [...]

List other issues or pull requests related to this problem

Example: This fixes #5012

Describe the solution you've chosen

Example: I've fixed this by [...]

Describe alternatives you've considered

Example: Another solution would be [...]

Checklist

Please add a x inside each checkbox:

  • The status checks are successful (continuous integration). Those can be seen below.

@erezrokah erezrokah added the type: bug code to address defects in shipped code label Jan 13, 2022
@XhmikosR XhmikosR marked this pull request as ready for review January 13, 2022 13:36
@XhmikosR XhmikosR requested a review from a team January 13, 2022 13:36
Copy link
Contributor

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
This is still helpful since it removes the need to upgrade that dependency. 👍

@ehmicky ehmicky merged commit 7362319 into netlify:main Jan 13, 2022
@XhmikosR XhmikosR deleted the rm-types-node branch January 13, 2022 14:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants