Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade Lighthouse and node #422

Merged
merged 12 commits into from
Jul 6, 2022
Merged

feat: upgrade Lighthouse and node #422

merged 12 commits into from
Jul 6, 2022

Conversation

FawazFarid
Copy link
Contributor

@FawazFarid FawazFarid commented Jul 1, 2022 •
edited
Loading

Summary

This PR does the following:

  • Update the node version for building the plugin to v16 since the Netlify system node version was upgraded to 16 recently, see this post.
  • Update Lighthouse to v9
  • Since this plugin is using Lighthouse v8, which supports Node 12. we are also removing support for Node 12 in the package.json engines.node field.
  • Update the Node version for CI because the minimum version of Node for Lighthouse v9 is v14. See this reference.

These changes should also allow us to unblock the CI build fails for the other PRs and future ones.

Relevant links

We can close this: #322

@FawazFarid FawazFarid changed the title Upgrade lh and node Upgrade Lighthouse and node Jul 1, 2022
@FawazFarid FawazFarid marked this pull request as ready for review July 4, 2022 14:48
nasivuela
nasivuela previously approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@nasivuela nasivuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Fawaz! Ship it 🚀

@nasivuela nasivuela self-requested a review July 4, 2022 15:07
@FawazFarid FawazFarid changed the title Upgrade Lighthouse and node chore: upgrade Lighthouse and node Jul 5, 2022
@FawazFarid FawazFarid changed the title chore: upgrade Lighthouse and node feat: upgrade Lighthouse and node Jul 5, 2022
@FawazFarid FawazFarid merged commit be93d56 into main Jul 6, 2022
@FawazFarid FawazFarid deleted the upgrade-lh-and-node branch July 6, 2022 14:30
FawazFarid added a commit that referenced this pull request Jul 6, 2022
@FawazFarid
Revert "feat: upgrade Lighthouse and node (#422)"
54722bf 
This reverts commit be93d56.
@FawazFarid FawazFarid mentioned this pull request Jul 6, 2022
Closed
@token-generator-app token-generator-app bot mentioned this pull request Jul 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nasivuela nasivuela nasivuela approved these changes

@kevinsamoei kevinsamoei kevinsamoei approved these changes

Assignees
No one assigned
Labels
type: chore type: feature
Projects
None yet
Milestone
No milestone
3 participants
@FawazFarid @nasivuela @kevinsamoei