fix: specify node version >=14.15 <18
#439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kevinsamoei
commented
Jul 11, 2022
•
kevinsamoei
commented
- Lighthouse v9 does not work with node v18
- This updates the node version in package.json to match anything between v14.15 and 18
- Updated tests to run on v17.9
kevinsamoei
changed the title
>=14.15 <18
nasivuela
reviewed
Jul 12, 2022
netlify.toml
Outdated
| @@ -3,7 +3,7 @@ command = "echo 'no op'" | |||
| publish = "example" | |||
|
|
|||
| [build.environment] | |||
| NODE_VERSION = "16.15.1" | |||
| NODE_VERSION = "17.9.1" | |||
There was a problem hiding this comment.
we don't have an LTS on v17.* so I set it to 16.15.1 which is an LTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.