fix(deps) Upgrade puppeteer to v 19.5.2 #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
馃懛 Deploy Preview for plugin-lighthouse processing.
|
aitchiss
changed the title
aitchiss
changed the title
aitchiss
changed the title
This was referenced Jan 16, 2023
aitchiss
added a commit
that referenced
this pull request
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/netlify/netlify-plugin-lighthouse/issues/510
Originally, the upgrade to Puppeteer 19.x was failing, and their docs advised
createBrowserFetcherwas to be deprecated, which is why we paused renovate updating this dependency.Now, however, it seems the issue we were seeing with a change to the args for
createBrowserFetcherhas been resolved, and their docs have been updated to statecreateBrowserFetcheris deprecated only for users ofpuppeteer-core(not us)TL;DR a minor version bump on their side has already fixed the issues, and we no longer have a deprecation to worry about 馃帀
Cypress specs are passing, and I've tested by pointing a site's
@netlify/plugin-lighthouseat this branch, and all looks fine to me.