This repository has been archived by the owner on Sep 8, 2021. It is now read-only.
Replace TOML parser to support 4.0 syntax. #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should probably update netlify-commons too right? |
|
@brycekahle yeah, but that's independent from this change. |
brycekahle
reviewed
Apr 11, 2018
configuration/configuration.go
Outdated
| } | ||
| defer f.Close() | ||
|
|
||
| fi, err := f.Stat() |
There was a problem hiding this comment.
This .Stat is probably not needed anymore since you cannot os.Open on a directory.
|
It looks like v0.3.0 of |
calavera
force-pushed
the
toml_parser
branch
4 times, most recently
from
d203cb7
to
5dd04a6
Compare
Signed-off-by: David Calavera <david.calavera@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102
Signed-off-by: David Calavera david.calavera@gmail.com