This repository has been archived by the owner on May 10, 2021. It is now read-only.
Update isRootCatchAllRedirect condition #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afzalsayed96
commented
Nov 13, 2020
| // (e.g., /[[...slug]] or /[...slug]) | ||
| const isRootCatchAllRedirect = (redirect) => | ||
| redirect.startsWith("/*") || | ||
| (redirect.startsWith("/:") && redirect.includes("/*")); |
There was a problem hiding this comment.
This probably could be improved with some regex or
(redirect.startsWith("/:") && redirect.trim().split(" ")[0].endsWith("/*");
|
@afzalsayed96 this is great! thanks so much for opening this and helping out <3 |
icodethings
pushed a commit
to SleepingDuck/next-on-netlify
that referenced
this pull request
Nov 15, 2020
* update isRootCatchAllRedirect condition
|
this has been published! |
icodethings
pushed a commit
to SleepingDuck/next-on-netlify
that referenced
this pull request
Nov 15, 2020
- Hotfix: no-cache Cache-Control for preview mode ([Commit](netlify@990b4a8)) - README updates - Update isRootCatchAllRedirect condition ([netlify#77](netlify#77))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @lindsaylevine,
This fix seems to work for the issue reported in #43 (comment)