fix: streamline no-shadow handling

netlify · May 2, 2023 · 66a9670 · 66a9670
1 parent 92dcf3a
commit 66a9670
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -48,6 +48,9 @@ module.exports = {
         'n/no-unsupported-features/es-syntax': 'off',
         '@typescript-eslint/no-extra-semi': 'off',
         'n/no-missing-import': 'off',
+        // https://github.com/typescript-eslint/typescript-eslint/issues/2483
+        'no-shadow': 'off',
+        '@typescript-eslint/no-shadow': 'error',
       },
     },
     {

diff --git a/packages/runtime/src/helpers/types.ts b/packages/runtime/src/helpers/types.ts
@@ -52,8 +52,6 @@ export interface RoutesManifest {
   rewrites: Rewrites
 }
 
-// I have no idea what eslint is up to here but it gives an error
-// eslint-disable-next-line no-shadow
 export const enum ApiRouteType {
   SCHEDULED = 'experimental-scheduled',
   BACKGROUND = 'experimental-background',