Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows support #21

Closed
ehmicky opened this issue Nov 10, 2020 · 2 comments · Fixed by #32
Closed

Windows support #21

ehmicky opened this issue Nov 10, 2020 · 2 comments · Fixed by #32
Assignees
@ehmicky
Labels
proj/non/next-on-netlify-enterprise type: feature code contributing to the implementation of a feature and/or user facing functionality

Comments

@ehmicky
Copy link

ehmicky commented Nov 10, 2020 •
edited

We should run CI tests on Windows and macOS as well, to ensure this plugin works for Netlify CLI users who run netlify build.

Many of our CLI users are on Windows (example for next-on-netlify).
@ehmicky ehmicky added type: feature code contributing to the implementation of a feature and/or user facing functionality proj/non/next-on-netlify-enterprise labels Nov 10, 2020
@ehmicky ehmicky self-assigned this Nov 13, 2020
@ehmicky ehmicky mentioned this issue Nov 13, 2020
Merged
@ehmicky
Copy link
Author

ehmicky commented Nov 13, 2020

Done at #32.

@ehmicky ehmicky mentioned this issue Nov 17, 2020
Closed
@ehmicky
Copy link
Author

ehmicky commented Nov 17, 2020

See also netlify/next-on-netlify#88

ascorbic added a commit that referenced this issue Oct 4, 2021
@ascorbic
chore: switch to tsc for building (#21)
0ee5b35
serhalp pushed a commit that referenced this issue Apr 5, 2024
@orinokai
Merge pull request #21 from netlify/rs/cache-control
ee5f379 
feat: add cache-control and vary handling to server handler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ehmicky ehmicky

Labels
proj/non/next-on-netlify-enterprise type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run tests on Windows netlify/next-runtime
1 participant
@ehmicky