-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Legacy fallback env var #2074
Merged
Merged
Changes from 8 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
05f528f
fix: legacy fallback env var
taty2010 6fbf91f
chore: prettier
taty2010 8f58d02
chore: added tests
taty2010 66d61c0
chore: added failOnStatusCode: false
taty2010 c11218b
fix: removed redirect test and odb check for dynamic tests
taty2010 aca6961
chore: removed cy test and added unit test
taty2010 cabf059
fix: forgot to export
taty2010 a949179
chore: updated readme
taty2010 81554c8
chore: remove it.only from tests
taty2010 457ba6a
fix: use destr
taty2010 d4876f7
chore: refactored tests
taty2010 a392a38
Merge branch 'main' into tn/legacyFallbackEnvVar
taty2010 a52411b
fix: imports
taty2010 96186b5
Merge branch 'main' into tn/legacyFallbackEnvVar
taty2010 ebec9b5
Update test/helpers/utils.spec.ts
taty2010 5e2e702
Update test/helpers/utils.spec.ts
taty2010 76ed3fe
Merge branch 'main' into tn/legacyFallbackEnvVar
LekoArts 14fac5d
chore: formatting
taty2010 eea4c03
Merge branch 'main' into tn/legacyFallbackEnvVar
taty2010 c82d4e5
chore: empty commit
taty2010 450c4b5
Merge branch 'main' into tn/legacyFallbackEnvVar
LekoArts ea49fd6
chore: delete env var at end of test
LekoArts 7a7b579
chore: linting
LekoArts File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work if folks use
LEGACY_FALLBACK_FALSE = 'false'
so we need to test for strings too. In other areas of the Runtime we've useddestr
so I'd suggest that as a convention: https://github.com/netlify/next-runtime/blob/split-api-routes/packages/runtime/src/index.ts#L106There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the heads up Rob and the ref code.