Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass query string to handler #719

Merged
merged 1 commit into from
Oct 18, 2021
Merged

fix: pass query string to handler #719

merged 1 commit into from
Oct 18, 2021

Conversation

ascorbic
Copy link
Contributor

Next server's query middleware expects the URL query params to be in the path

Fixes #706 (comment)

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Oct 18, 2021
@ascorbic ascorbic requested a review from a team October 18, 2021 12:43
lindsaylevine
lindsaylevine approved these changes Oct 18, 2021
View reviewed changes
Copy link

@lindsaylevine lindsaylevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!!! ftr i figured it was this so thats why i didnt ask the reporter for a repo/repro.

@ascorbic
Copy link
Contributor Author

It took me far too long to work out where/how I should pass it through to Next!

@ascorbic ascorbic merged commit ff09cae into main Oct 18, 2021
@ascorbic ascorbic deleted the fix/api-query branch October 18, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindsaylevine lindsaylevine lindsaylevine approved these changes

Assignees
No one assigned
Labels
type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ascorbic @lindsaylevine