Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dns_zones API #211

Merged
merged 5 commits into from May 8, 2020
Merged

Add dns_zones API #211

merged 5 commits into from May 8, 2020

Conversation

bertvansteen
Copy link

@bertvansteen bertvansteen commented Jan 22, 2020

This PR is a continuation of PR #163, all credits go to @futuregerald for describing the initial API, I implemented the changes requested by @kitop.

PR #207 is also related: that PR is missing the generated GO code.

@netlify
Copy link

netlify bot commented Jan 22, 2020

Deploy preview for open-api ready!

Built with commit c6ec6b5

https://deploy-preview-211--open-api.netlify.app

@bertvansteen bertvansteen changed the title Gerald/dns zones Add dns_zones API Jan 23, 2020
@bertvansteen
Copy link
Author

Any update on this PR? There are 3 PR's open for the same API. I want to add the DNS capability to the netlify-terraform provider.

@ldez ldez mentioned this pull request Mar 5, 2020
@bertvansteen bertvansteen requested a review from a team as a code owner March 12, 2020 00:06
@ldez
Copy link
Contributor

ldez commented Mar 20, 2020

@bertvansteen I had a lot of expectations on this PR. Are you closing it because no one is responding or because there has been a change in the code base?

@ehmicky ehmicky reopened this Mar 20, 2020
@ehmicky
Copy link
Contributor

ehmicky commented Mar 20, 2020

Sorry for not code reviewing this faster @bertvansteen @ldez
I unfortunately cannot help here since I don't know Go.

@mraerino @vbrown608 @kitop Would you be able to check it out? Thanks!

@ldez
Copy link
Contributor

ldez commented Apr 25, 2020

Friendly ping @mraerino @vbrown608 @kitop

@kitop
Copy link
Contributor

kitop commented Apr 27, 2020

Hi @bertvansteen and @ldez, looking at it now, and noticed it doesn't show in the deploy preview. Can you rebase and add tags: [dnsZone] to all new endpoints so they show in the sidebar?

@bertvansteen
Copy link
Author

Thanks @kitop, I rebased the branch, added the [dns] tag and ran "make all" inside a golang;1.13 docker container.

swagger.yml Outdated Show resolved Hide resolved
swagger.yml Outdated Show resolved Hide resolved
swagger.yml Show resolved Hide resolved
swagger.yml Outdated Show resolved Hide resolved
@keiko713
Copy link
Contributor

thanks for the contribution 🎉 I went and left several notes, mostly the small ones or additional params (but didn't update it consistently, I'm likely missing something), overall it's looking good :)
also, I'm sorry but I just merged the PR of switching CI from travis to GitHub Action after your rebase. another rebase would be nice, but not required.

@bertvansteen
Copy link
Author

no problem, I'll adopt the suggested changes and will do a rebase.

Copy link
Contributor

@keiko713 keiko713 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry forgot to circle back here. Thanks for the rebase, looking great! Going to merge this.
I'm going to wait the release a bit as there are other open PRs that could go with this.

@keiko713 keiko713 merged commit d822ba7 into netlify:master May 8, 2020
@bertvansteen bertvansteen deleted the gerald/dns_zones branch May 11, 2020 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants