New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dns_zones API #211
Add dns_zones API #211
Conversation
Deploy preview for open-api ready! Built with commit c6ec6b5 |
Any update on this PR? There are 3 PR's open for the same API. I want to add the DNS capability to the netlify-terraform provider. |
@bertvansteen I had a lot of expectations on this PR. Are you closing it because no one is responding or because there has been a change in the code base? |
Sorry for not code reviewing this faster @bertvansteen @ldez @mraerino @vbrown608 @kitop Would you be able to check it out? Thanks! |
Friendly ping @mraerino @vbrown608 @kitop |
Hi @bertvansteen and @ldez, looking at it now, and noticed it doesn't show in the deploy preview. Can you rebase and add |
Thanks @kitop, I rebased the branch, added the [dns] tag and ran "make all" inside a golang;1.13 docker container. |
thanks for the contribution 🎉 I went and left several notes, mostly the small ones or additional params (but didn't update it consistently, I'm likely missing something), overall it's looking good :) |
no problem, I'll adopt the suggested changes and will do a rebase. |
Addressing PR comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry forgot to circle back here. Thanks for the rebase, looking great! Going to merge this.
I'm going to wait the release a bit as there are other open PRs that could go with this.
This PR is a continuation of PR #163, all credits go to @futuregerald for describing the initial API, I implemented the changes requested by @kitop.
PR #207 is also related: that PR is missing the generated GO code.