This repository has been archived by the owner on Oct 14, 2020. It is now read-only.
Add Docker image #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brycekahle
reviewed
May 7, 2018
Dockerfile
Outdated
| @@ -0,0 +1,11 @@ | |||
| FROM golang:1.10.1 | |||
There was a problem hiding this comment.
1.10.2 is out, might as well use that.
brycekahle
reviewed
May 7, 2018
Dockerfile
Outdated
|
|
||
| FROM alpine:3.7 | ||
| RUN apk add --no-cache ca-certificates | ||
| RUN mkdir /lib64 && ln -s /lib/libc.musl-x86_64.so.1 /lib64/ld-linux-x86-64.so.2 |
There was a problem hiding this comment.
I don't think this is necessary. The only reason gotrue had it was because of a library that was using cgo.
There was a problem hiding this comment.
I had to do it because the binary was looking for that library. I guess it's related to not doing an static build
brycekahle
reviewed
May 7, 2018
Dockerfile
Outdated
| FROM golang:1.10.1 | ||
| WORKDIR /go/src/github.com/netlify/twickr | ||
| COPY . /go/src/github.com/netlify/twickr/ | ||
| RUN go get && go build |
There was a problem hiding this comment.
For a static build, we need to add CGO_ENABLED=0. We should also setup glide to vendor the dependencies. I'm happy to do that if you want.
There was a problem hiding this comment.
I'll add the glide setup 👌
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.