This repository has been archived by the owner on May 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 35
fix: add error message if unable to find cron expression for scheduled function #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: chore
work needed to keep the product and development running smoothly
label
Jun 23, 2022
β± Benchmark resultsComparing with 7e21b63 largeDepsEsbuild: 7.7sβ¬οΈ 26.18% increase vs. 7e21b63
LegendlargeDepsNft: 39.3sβ¬οΈ 23.63% increase vs. 7e21b63
LegendlargeDepsZisi: 55.1sβ¬οΈ 20.61% increase vs. 7e21b63
|
danez
suggested changes
Jun 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the simplicity of the approach. I thought there would be a lot more changes involved. Besides the one case that is missing (see comments), I think this is the way to go.
danez
previously approved these changes
Jun 26, 2022
...tures/in-source-config/functions_missing_cron_expression/cron_cjs_invalid_cron_expression.js
Show resolved
Hide resolved
danez
approved these changes
Jun 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello from pto :) lgtm
If you want a release after merging you would need to change the type in the squash commit or pr title if using kodiak from chore to fix
jenae-janzen
changed the title
chore: add error message if unable to find cron expression for scheduled function
fix: add error message if unable to find cron expression for scheduled function
Jun 27, 2022
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
May 21, 2024
β¦d function (netlify/zip-it-and-ship-it#1123) * fix: add error message if cron expression not found or invalid in isc of scheduled funcs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
type: bug
code to address defects in shipped code
type: chore
work needed to keep the product and development running smoothly
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Thanks for submitting a pull request! π
Summary
Fixes #<1108>
Checks to make sure that scheduled functions aren't missed. If the
schedule
helper is imported but not correctly invoked/exported, assumes user wanted to schedule the function and throws an error.For us to review and ship your PR efficiently, please perform the following steps:
This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing
a typo or something that`s on fire π₯ (e.g. incident related), you can skip this step.
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)