This repository has been archived by the owner on May 22, 2024. It is now read-only.
feat: Make additional function attributes available via functions manifest #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackiewmacharia
changed the title
⏱ Benchmark resultsComparing with de48712 largeDepsEsbuild: 3s⬆️ 32.68% increase vs. de48712 LegendlargeDepsNft: 11.9s⬆️ 36.19% increase vs. de48712 LegendlargeDepsZisi: 21.6s⬆️ 30.92% increase vs. de48712 |
jackiewmacharia
changed the title
github-actions
bot
added
the
type: feature
khendrikse
force-pushed
the
feat/pass-additional-function-attributes
branch
from
c656390
to
f5993ec
Compare
danez
previously requested changes
Jan 10, 2023
khendrikse
force-pushed
the
feat/pass-additional-function-attributes
branch
3 times, most recently
from
731567f
to
dd92b53
Compare
… functions folder
…playName property
…isplayName property
khendrikse
force-pushed
the
feat/pass-additional-function-attributes
branch
from
763f07d
to
9f5b99b
Compare
This was referenced Feb 8, 2023
Merged
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
May 21, 2024
…ifest (netlify/zip-it-and-ship-it#1221) * feat: pass additional-function-attributes * chore: make attributes available to functions manifest * fix: fix linting * fix: use optional chaining * fix: add ext * fix: fix tests * fix: change internal directory name in constants.ts * feat: add test for go functions with displayName and from an internal functions folder * feat: add test for rust functions build from internal folder with displayName property * feat: add test for nodejs functions build from internal folder with displayName property * test: figure out windows breakn * fix: take windows paths into account when checking for internal functions * test: add unit test for checkIsInternalFunction * docs: add new return values * test: move tests into a better fixtures structure * fix: use unixify for checkIsInternalFunction, config, bundler, module and resolve * feat: add internalFunctionsFolder option to zipfunctionoptions * test: fix tests * test: add test for zipFunction and code to support that as well * test: change toBeTruthy to toBe(true) and isInternalFunction to internalFunction * chore: change displayName input to name * chore: change internalFunction to isInternal * chore: revert unixify, rename tests and internalFunctionsFolder to internalSrcFolder * test: revert unixify for module to see if windows test still fails * Revert "test: revert unixify for module to see if windows test still fails" This reverts commit b444d1c4828965d72d909d96fa68e531a888d221. Co-authored-by: khen <30577427+khendrikse@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Issue: https://github.com/netlify/pod-compute/issues/192
Issue: https://github.com/netlify/pod-compute/issues/156
Makes displayName, nodeBundler and isInternalFunction available to the API
For us to review and ship your PR efficiently, please perform the following steps:
This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing
a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)