fix: generate entry file on naming conflicts

[danez]

Summary

When a naming conflict occurs we need to create a entry file even if there is already a similar named file, but it will be moved to a subfolder.

Fixes the nuxt3 problem

when a functions has this layout

netlify/functions/server/
                         server.js <-- detected as main file
                         server.mjs

previously we would leave everything as is, as server.js is the main file and has the same name as the entry file so nothing to do.

With #1190 we now consider server.mjs also as a potential entry file and detect that it can potentially conflict with the entry file, so we move everything from that function into a subfolder.

netlify/functions/server/src/
                             server.js
                             server.mjs

when we do this we now need to generate an entry file again, even though we would detect that server.js would satisfy as entry-point, but due to everything being moved into a subfolder we need to.

netlify/functions/server/src/
                             server.js
                             server.mjs
                         server.js

And the chain in this scenario is ./server.js -> ./src/server.js -> ./src/server.mjs

This is all not optimal, and we should prioritize changing the AWS entry point to something unique like __netlifyLambdaEntry and disallow a function to be named like that. Then all of this code can be removed.

[github-actions]

⏱ Benchmark results

Comparing with ea4008e

largeDepsEsbuild: 2.1s

⬇️ 3.43% decrease vs. ea4008e

^                                                    3s                                   
│                                                   ┌──┐    2.8s                          
│                                                   |  |    ┌──┐                          
│           2.6s                                    |  |    |  |                          
│           ┌──┐                                    |  |    |  |                          
│           |  |    2.2s                    2.1s    |  |    |  |            2.1s          
│ ───2s─────┼──┼────┌──┐────2.1s────2.1s────┌──┐────┼──┼────┼──┼─────2s─────┌──┐────2.1s──
│   ┌──┐    |  |    |  |    ┌──┐    ┌──┐    |  |    |  |    |  |    ┌──┐    |  |    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    

Legend

• T-10 (9160543): 2s
• T-9 (298c68c): 2.6s
• T-8 (34309e2): 2.2s
• T-7 (2449c71): 2.1s
• T-6 (40e5a58): 2.1s
• T-5 (d4327a3): 2.1s
• T-4 (a894743): 3s
• T-3 (977a39d): 2.8s
• T-2 (de48712): 2s
• T-1 (ea4008e): 2.1s
• T (current commit): 2.1s

largeDepsNft: 7.4s

⬇️ 9.24% decrease vs. ea4008e

^          13.4s                                                                          
│           ┌──┐                                                                          
│           |  |                                   11.8s                                  
│           |  |                                    ┌──┐                                  
│           |  |   10.6s                            |  |   10.9s                          
│           |  |    ┌──┐   10.3s                    |  |    ┌──┐                          
│ ──9.4s────┼──┼────┼──┼────┌──┐────9.7s────────────┼──┼────┼──┼──────────────────────────
│   ┌──┐    |  |    |  |    |  |    ┌──┐            |  |    |  |                          
│   |  |    |  |    |  |    |  |    |  |     8s     |  |    |  |            8.1s          
│   |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    7.6s    ┌──┐    7.4s  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    

Legend

• T-10 (9160543): 9.4s
• T-9 (298c68c): 13.4s
• T-8 (34309e2): 10.6s
• T-7 (2449c71): 10.3s
• T-6 (40e5a58): 9.7s
• T-5 (d4327a3): 8s
• T-4 (a894743): 11.8s
• T-3 (977a39d): 10.9s
• T-2 (de48712): 7.6s
• T-1 (ea4008e): 8.1s
• T (current commit): 7.4s

largeDepsZisi: 14.7s

⬇️ 5.49% decrease vs. ea4008e

^                                                  21.2s   20.7s                          
│                                                   ┌──┐    ┌──┐                          
│          18.9s                                    |  |    |  |                          
│           ┌──┐                                    |  |    |  |                          
│           |  |   16.8s                            |  |    |  |                          
│ ──────────┼──┼────┌──┐───15.6s───────────15.8s────┼──┼────┼──┼───────────15.5s──────────
│  14.4s    |  |    |  |    ┌──┐   15.3s    ┌──┐    |  |    |  |   14.9s    ┌──┐   14.7s  
│   ┌──┐    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    ┌──┐    |  |    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    

Legend

• T-10 (9160543): 14.4s
• T-9 (298c68c): 18.9s
• T-8 (34309e2): 16.8s
• T-7 (2449c71): 15.6s
• T-6 (40e5a58): 15.3s
• T-5 (d4327a3): 15.8s
• T-4 (a894743): 21.2s
• T-3 (977a39d): 20.7s
• T-2 (de48712): 14.9s
• T-1 (ea4008e): 15.5s
• T (current commit): 14.7s

[eduardoboucas]

Do you mind adding a couple of examples to the PR description so that it's easier to understand what happens exactly in the cases we're targeting?

[danez]

Do you mind adding a couple of examples to the PR description so that it's easier to understand what happens exactly in the cases we're targeting?

Done

[eduardoboucas]

This is all not optimal, and we should prioritize changing the AWS entry point to something unique like __netlifyLambdaEntry and disallow a function to be named like that. Then all of this code can be removed.

Agreed. Do we have an issue for tracking that work? If not, do you mind creating one?

[danez]

Agreed. Do we have an issue for tracking that work? If not, do you mind creating one?

It is part of the notion doc about all the improvements for zip-it-and-ship-it.