feat: add `priority` field to manifest #1705

eduardoboucas · 2024-01-30T16:51:59Z

Summary

Adds a priority field to the functions manifest file based on whether it was generated by an integration or authored by a user.

Part of COM-327.

github-actions · 2024-01-30T16:53:27Z

⏱ Benchmark results

Comparing with 64ee032

largeDepsEsbuild: 1.4s

⬆️ 1.77% increase vs. 64ee032

^                                           1.5s    1.5s            1.5s            1.5s                  
│   1.5s    1.4s    1.4s    1.5s    1.4s    ┌──┐    ┌──┐    1.4s    ┌──┐    1.4s    ┌──┐    1.4s    1.4s  
│ ──┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┼──┼────┼──┼────┌──┐────┼──┼────┌──┐────┼──┼────┌──┐────┌──┐──
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (d40e8dd): 1.4s
T-29 (dc6d7a5): 1.4s
T-28 (31faa09): 1.4s
T-27 (0f23aa8): 1.4s
T-26 (e151134): 1.4s
T-25 (f5fb309): 1.4s
T-24 (cff8955): 1.5s
T-23 (be424b2): 1.5s
T-22 (f146798): 1.4s
T-21 (c7901aa): 1.4s
T-20 (bc7b0b8): 1.5s
T-19 (81e451b): 1.4s
T-18 (daa74ff): 1.4s
T-17 (128b059): 1.4s
T-16 (f01af04): 1.5s
T-15 (44f2871): 1.4s
T-14 (a176e52): 1.5s
T-13 (897284e): 1.5s
T-12 (30703f8): 1.5s
T-11 (ec7bde9): 1.4s
T-10 (05b3c1a): 1.4s
T-9 (393b490): 1.5s
T-8 (abcba24): 1.4s
T-7 (1b10dd1): 1.5s
T-6 (46377da): 1.5s
T-5 (1a06dac): 1.4s
T-4 (8a3845d): 1.5s
T-3 (8ebae9d): 1.4s
T-2 (655f1a8): 1.5s
T-1 (64ee032): 1.4s
T (current commit): 1.4s

largeDepsNft: 5.8s

⬆️ 1.91% increase vs. 64ee032

^                                           5.8s    5.8s                                    5.7s    5.8s  
│   5.5s    5.5s    5.5s    5.6s    5.5s    ┌──┐    ┌──┐    5.6s            5.6s    5.5s    ┌──┐    ┌──┐  
│ ──┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┼──┼────┼──┼────┌──┐────5.3s────┌──┐────┌──┐────┼──┼────|▒▒|──
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (d40e8dd): 5.6s
T-29 (dc6d7a5): 5.5s
T-28 (31faa09): 5.5s
T-27 (0f23aa8): 5.6s
T-26 (e151134): 5.4s
T-25 (f5fb309): 5.4s
T-24 (cff8955): 5.5s
T-23 (be424b2): 5.8s
T-22 (f146798): 5.5s
T-21 (c7901aa): 5.5s
T-20 (bc7b0b8): 5.6s
T-19 (81e451b): 5.5s
T-18 (daa74ff): 5.4s
T-17 (128b059): 5.7s
T-16 (f01af04): 5.5s
T-15 (44f2871): 5.6s
T-14 (a176e52): 5.8s
T-13 (897284e): 5.5s
T-12 (30703f8): 5.5s
T-11 (ec7bde9): 5.5s
T-10 (05b3c1a): 5.5s
T-9 (393b490): 5.6s
T-8 (abcba24): 5.5s
T-7 (1b10dd1): 5.8s
T-6 (46377da): 5.8s
T-5 (1a06dac): 5.6s
T-4 (8a3845d): 5.3s
T-3 (8ebae9d): 5.6s
T-2 (655f1a8): 5.5s
T-1 (64ee032): 5.7s
T (current commit): 5.8s

largeDepsZisi: 10.5s

⬇️ 1.17% decrease vs. 64ee032

^                  10.5s   10.6s           10.7s   10.6s   10.5s   10.5s                   10.6s   10.5s  
│  10.2s   10.4s    ┌──┐    ┌──┐   10.1s    ┌──┐    ┌──┐    ┌──┐    ┌──┐   10.3s   10.4s    ┌──┐    ┌──┐  
│   ┌──┐    ┌──┐    |  |    |  |    ┌──┐    |  |    |  |    |  |    |  |    ┌──┐    ┌──┐    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (d40e8dd): 10.6s
T-29 (dc6d7a5): 10.4s
T-28 (31faa09): 10.4s
T-27 (0f23aa8): 10.4s
T-26 (e151134): 10.3s
T-25 (f5fb309): 10.4s
T-24 (cff8955): 10.5s
T-23 (be424b2): 10.6s
T-22 (f146798): 10.4s
T-21 (c7901aa): 10.5s
T-20 (bc7b0b8): 10.5s
T-19 (81e451b): 9.9s
T-18 (daa74ff): 10.3s
T-17 (128b059): 10.7s
T-16 (f01af04): 10.4s
T-15 (44f2871): 10.1s
T-14 (a176e52): 10.4s
T-13 (897284e): 10s
T-12 (30703f8): 10.2s
T-11 (ec7bde9): 10.4s
T-10 (05b3c1a): 10.5s
T-9 (393b490): 10.6s
T-8 (abcba24): 10.1s
T-7 (1b10dd1): 10.7s
T-6 (46377da): 10.6s
T-5 (1a06dac): 10.5s
T-4 (8a3845d): 10.5s
T-3 (8ebae9d): 10.3s
T-2 (655f1a8): 10.4s
T-1 (64ee032): 10.6s
T (current commit): 10.5s

lukasholzer

LGTM!

* feat: add `priority` field to manifest * chore: fix test

feat: add priority field to manifest

1eadc33

eduardoboucas requested a review from a team as a code owner January 30, 2024 16:52

chore: fix test

fb81736

eduardoboucas requested review from lukasholzer and JGAntunes January 31, 2024 15:07

lukasholzer approved these changes Jan 31, 2024

View reviewed changes

eduardoboucas merged commit f129ca1 into main Jan 31, 2024
10 checks passed

eduardoboucas deleted the feat/manifest-priority branch January 31, 2024 15:56

token-generator-app bot mentioned this pull request Jan 31, 2024

chore(main): release 9.29.0 #1706

Merged

Skn0tt pushed a commit to netlify/build that referenced this pull request May 21, 2024

feat: add priority field to manifest (netlify/zip-it-and-ship-it#1705)

df223e8

* feat: add `priority` field to manifest * chore: fix test

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add `priority` field to manifest #1705

feat: add `priority` field to manifest #1705

eduardoboucas commented Jan 30, 2024

github-actions bot commented Jan 30, 2024 •

edited

lukasholzer left a comment

feat: add priority field to manifest #1705

feat: add priority field to manifest #1705

Conversation

eduardoboucas commented Jan 30, 2024

Summary

github-actions bot commented Jan 30, 2024 • edited

⏱ Benchmark results

largeDepsEsbuild: 1.4s

largeDepsNft: 5.8s

largeDepsZisi: 10.5s

lukasholzer left a comment

Choose a reason for hiding this comment

feat: add `priority` field to manifest #1705

feat: add `priority` field to manifest #1705

github-actions bot commented Jan 30, 2024 •

edited