Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

fix: sanitise package.json files field #800

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

netlify-team-account-1
Copy link
Contributor

- Summary

Some packages have a malformed files field. This PR adds sanitisation to catch that.

- Test plan

  • added unit test

- A picture of a cute animal (not mandatory but encouraged)

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Nov 9, 2021
eduardoboucas
eduardoboucas previously approved these changes Nov 9, 2021
Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

src/runtimes/node/utils/package_json.ts Outdated Show resolved Hide resolved
src/runtimes/node/utils/package_json.ts Outdated Show resolved Hide resolved
src/runtimes/node/utils/package_json.ts Outdated Show resolved Hide resolved
src/runtimes/node/utils/package_json.ts Outdated Show resolved Hide resolved
src/runtimes/node/utils/package_json.ts Outdated Show resolved Hide resolved
Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>
@netlify-team-account-1 netlify-team-account-1 merged commit 6c82ada into main Nov 9, 2021
@netlify-team-account-1 netlify-team-account-1 deleted the sanitise-package-json-files branch November 9, 2021 14:51
Skn0tt pushed a commit to netlify/build that referenced this pull request May 21, 2024
* fix: sanitise package.json files field

* Apply suggestions from code review

Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>

Co-authored-by: Netlify Team Account 1 <netlify-team-account-1@users.noreply.github.com>
Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants