Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse Cisco parsers #20

Closed
marshall-sg opened this issue Apr 17, 2020 · 0 comments · Fixed by #24
Closed

Collapse Cisco parsers #20

marshall-sg opened this issue Apr 17, 2020 · 0 comments · Fixed by #24
Assignees
Labels
Enhancement Enhance existing tool for end user. Question Maybe an issue, but more thought/discussion needed. TODO Changes to code generally transparent to end users.

Comments

@marshall-sg
Copy link
Collaborator

Question
Should we collapse the Cisco type routers to one tool with options instead?

Is your enhancement request related to a problem? Please describe.
The configs between them are generally similar, there are outliers though (e.g, the wireless device configs). So this means much of the logic is the same between the parsers. When issues arise, we have to fix for multiple (unless it is forgotten) and usually this results in copy paste code. We may be able to do better.

Describe the solution you'd like
Explore collapsing the logic into a single parsing tool. I advise against a single monolithic parser, in favor of a multi-branch parser. This would allow the flexibility to give the end-user an option to explicitly specify which parser to leverage (e.g., --ios, --nxos, etc.). Also, this hopefully will allow logic re-use between the parsers in a cleaner manner.

Describe alternatives you've considered
Current solution leverages multiple tools.

Additional context
None.

@marshall-sg marshall-sg added Enhancement Enhance existing tool for end user. TODO Changes to code generally transparent to end users. Question Maybe an issue, but more thought/discussion needed. labels Apr 17, 2020
@marshall-sg marshall-sg self-assigned this Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Enhance existing tool for end user. Question Maybe an issue, but more thought/discussion needed. TODO Changes to code generally transparent to end users.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant