Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can "revision-label" be used in include? #20

Closed
rgwilton opened this issue Jun 10, 2019 · 3 comments
Closed

Can "revision-label" be used in include? #20

rgwilton opened this issue Jun 10, 2019 · 3 comments
Labels
updated-mod-rev-handling Issues related to yang-module-versioning (updated module revision handling draft)

Comments

@rgwilton
Copy link
Collaborator

Can a revision-label be used instead of a revision-date in "include" or "import specific revision"?

Or do we just defer this to a new version of YANG (e.g. track as part of YANG.Next)? [My preference]

Or do we define separate extension statements [I'm not keen on this]

@rgwilton rgwilton added the updated-mod-rev-handling Issues related to yang-module-versioning (updated module revision handling draft) label Jun 10, 2019
@BalazsLengyel
Copy link
Collaborator

BalazsLengyel commented Jun 11, 2019 via email

@sunseawq
Copy link
Collaborator

I agree with Balazs, suggest
1.not include revision label in the submodule level and inherit revision label from the versioned main module if the main module included revision label.
2. not have revision label in the include statement.
The reason is when a module have multiple submodule and revision label of each submodule is different, it is hard to decide revision-label for the versioned main module. if each submodule have the same revision label, why not simply inherit revison label for the versioned main module

@rgwilton
Copy link
Collaborator Author

Agreed that this can be done in a future version of YANG, but not now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
updated-mod-rev-handling Issues related to yang-module-versioning (updated module revision handling draft)
Projects
None yet
Development

No branches or pull requests

3 participants