[ENH] added parallelization to dominance analysis function #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It didn't pass the style check so I'm going to reupload a fancier version 😅 |
liuzhenqi77
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Thanks for the PR! Looks good to me!
Just make sure you've tested a few examples for equivalence before & after change.
And you're good to merge!
(The internal multiprocessing I mentioned seems to have been managed by joblib well haha.)
|
I did some tests and it turns out that the version with parallelization produces different array for partial and total dominance sometimes. These are, however, only very minor. Checking with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model R2s for dominance analysis are now computed in parallel