Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-984 - KafkaInterBrokerProtocalVersion throws warning and has ingestion errors #428

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

jpinsonneau
Copy link
Collaborator

@jpinsonneau jpinsonneau commented Apr 26, 2023

Rely on TimeFlowEndMs for kafka delay as the Decode function returns a GenericMap that doesn't contains TimeFlowEnd.

Related PRs:
https://github.com/netobserv/flowlogs-pipeline/pull/203/files
https://github.com/netobserv/network-observability-console-plugin/pull/153/files

@jpinsonneau jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 26, 2023
@github-actions
Copy link

New image: quay.io/netobserv/flowlogs-pipeline:bf793ba. It will expire after two weeks.

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #428 (812a7fa) into main (4aee357) will decrease coverage by 0.03%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
- Coverage   64.72%   64.70%   -0.03%     
==========================================
  Files          94       94              
  Lines        6645     6649       +4     
==========================================
+ Hits         4301     4302       +1     
- Misses       2100     2103       +3     
  Partials      244      244              
Flag Coverage Δ
unittests 64.70% <33.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/pipeline/decode/decode_protobuf.go 76.00% <0.00%> (-1.56%) ⬇️
pkg/pipeline/ingest/ingest_grpc.go 75.00% <0.00%> (-1.06%) ⬇️
pkg/pipeline/ingest/ingest_kafka.go 65.38% <42.85%> (-0.18%) ⬇️

Copy link
Contributor

@OlivierCazade OlivierCazade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathan-weinberg
Copy link

@jpinsonneau @OlivierCazade i can test this on a fresh cluster tmrw, let me know if you seen any issues with the fix on the Baremetal cluster

@nathan-weinberg
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Apr 27, 2023
@jpinsonneau
Copy link
Collaborator Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Apr 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 95395fc into netobserv:main Apr 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants