-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1107: Update cilium to v0.11.0 #147
NETOBSERV-1107: Update cilium to v0.11.0 #147
Conversation
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
/ok-to-test |
New image: quay.io/netobserv/netobserv-ebpf-agent:0590990. It will expire after two weeks. |
Codecov Report
@@ Coverage Diff @@
## main #147 +/- ##
=======================================
Coverage 39.00% 39.00%
=======================================
Files 31 31
Lines 2238 2238
=======================================
Hits 873 873
Misses 1314 1314
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @msherif1234 does it requires special testing ? Have you noticed a performance impact ?
cc: @memodi
No just passing e2e and manual testing on cluster-bot is sufficient, performance attached below memory looks much better cpu is about the same |
25% memory gain 🥳 |
@msherif1234 @jpinsonneau - is there a JIRA tracking this change? cc @nathan-weinberg |
actually can be part of NETOBSERV-110 |
@msherif1234: This pull request references NETOBSERV-110 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@msherif1234: This pull request references NETOBSERV-1107 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Correct JIRA tracker is https://issues.redhat.com//browse/NETOBSERV-1107 |
https://github.com/cilium/ebpf/releases/tag/v0.11.0