Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1107: Update cilium to v0.11.0 #147

Merged
merged 1 commit into from
Jul 11, 2023
Merged

NETOBSERV-1107: Update cilium to v0.11.0 #147

merged 1 commit into from
Jul 11, 2023

Conversation

msherif1234
Copy link
Contributor

@msherif1234 msherif1234 commented Jul 10, 2023

Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 10, 2023
@github-actions
Copy link

New image: quay.io/netobserv/netobserv-ebpf-agent:0590990. It will expire after two weeks.

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #147 (9f7b677) into main (de8537f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #147   +/-   ##
=======================================
  Coverage   39.00%   39.00%           
=======================================
  Files          31       31           
  Lines        2238     2238           
=======================================
  Hits          873      873           
  Misses       1314     1314           
  Partials       51       51           
Flag Coverage Δ
unittests 39.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @msherif1234 does it requires special testing ? Have you noticed a performance impact ?

cc: @memodi

@msherif1234
Copy link
Contributor Author

msherif1234 commented Jul 10, 2023

LGTM, @msherif1234 does it requires special testing ? Have you noticed a performance impact ?

cc: @memodi

No just passing e2e and manual testing on cluster-bot is sufficient, performance attached below memory looks much better cpu is about the same
cilium_v0110

@jpinsonneau
Copy link
Contributor

No just passing e2e and manual testing on cluster-bot is sufficient, performance attached below memory looks much better cpu is about the same

25% memory gain 🥳
Have you checked the records output count to ensure it's similar & dropped count is still 0 ?

@memodi
Copy link
Contributor

memodi commented Jul 10, 2023

@msherif1234 @jpinsonneau - is there a JIRA tracking this change? cc @nathan-weinberg

@msherif1234
Copy link
Contributor Author

msherif1234 commented Jul 10, 2023

@msherif1234 @jpinsonneau - is there a JIRA tracking this change? cc @nathan-weinberg

actually can be part of NETOBSERV-110

@msherif1234 msherif1234 changed the title update cilium to v0.11.0 NETOBSERV-110: Update cilium to v0.11.0 Jul 10, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jul 10, 2023

@msherif1234: This pull request references NETOBSERV-110 which is a valid jira issue.

In response to this:

https://github.com/cilium/ebpf/releases/tag/v0.11.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msherif1234 msherif1234 changed the title NETOBSERV-110: Update cilium to v0.11.0 NETOBSERV-1107: Update cilium to v0.11.0 Jul 10, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jul 10, 2023

@msherif1234: This pull request references NETOBSERV-1107 which is a valid jira issue.

In response to this:

https://github.com/cilium/ebpf/releases/tag/v0.11.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msherif1234
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 47f7dff into netobserv:main Jul 11, 2023
10 checks passed
@davegord
Copy link

Correct JIRA tracker is https://issues.redhat.com//browse/NETOBSERV-1107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved jira/valid-reference lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants