Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-926: Fix kafka writer configuration ... [1.4 backport] #207

Merged
merged 1 commit into from Oct 12, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Oct 12, 2023

Backporting #195

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 12, 2023

@jotak: This pull request references NETOBSERV-926 which is a valid jira issue.

In response to this:

Backporting #195

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4f4851d) 39.51% compared to head (351aca4) 39.56%.
Report is 2 commits behind head on release-1.4.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.4     #207      +/-   ##
===============================================
+ Coverage        39.51%   39.56%   +0.04%     
===============================================
  Files               31       31              
  Lines             2394     2391       -3     
===============================================
  Hits               946      946              
+ Misses            1391     1388       -3     
  Partials            57       57              
Flag Coverage Δ
unittests 39.56% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/agent/agent.go 37.84% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Amoghrd
Copy link

Amoghrd commented Oct 12, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 12, 2023
@github-actions
Copy link

New image:
quay.io/netobserv/netobserv-ebpf-agent:48944fd

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=48944fd make set-agent-image

@msherif1234
Copy link
Contributor

/lgtm

@Amoghrd
Copy link

Amoghrd commented Oct 12, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Oct 12, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 12, 2023

@jotak: This pull request references NETOBSERV-926 which is a valid jira issue.

In response to this:

Backporting #195

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jotak
Copy link
Member Author

jotak commented Oct 12, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@OlivierCazade OlivierCazade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@openshift-ci openshift-ci bot merged commit 5b0f2f7 into netobserv:release-1.4 Oct 12, 2023
11 checks passed
@jotak jotak deleted the backport-kafka-fix branch November 1, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved jira/valid-reference lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants