Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config enable to enable pkt drop in ebpf #258

Closed
wants to merge 1 commit into from

Conversation

msherif1234
Copy link
Contributor

Description

its noticed in rhel9.3 the tracepoint and tracing hooks are loaded unconditionally even with the userspace enabling them which is different that rhel9.2

so far all features has enable flags except pktdrop this PR add flag for pkt drop

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@msherif1234
Copy link
Contributor Author

msherif1234 commented Jan 30, 2024

image

@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 30, 2024
Copy link

New image:
quay.io/netobserv/netobserv-ebpf-agent:459f30c

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=459f30c make set-agent-image

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (340f97c) 33.65% compared to head (07387bf) 33.59%.

Files Patch % Lines
pkg/ebpf/tracer.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
- Coverage   33.65%   33.59%   -0.06%     
==========================================
  Files          40       40              
  Lines        3542     3548       +6     
==========================================
  Hits         1192     1192              
- Misses       2281     2287       +6     
  Partials       69       69              
Flag Coverage Δ
unittests 33.59% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jpinsonneau
jpinsonneau previously approved these changes Feb 1, 2024
Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @msherif1234 !

@nathan-weinberg
Copy link

/hold

Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 1, 2024
@openshift-ci openshift-ci bot removed the lgtm label Feb 1, 2024
Copy link

openshift-ci bot commented Feb 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jpinsonneau. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 1, 2024
Copy link

github-actions bot commented Feb 1, 2024

New image:
quay.io/netobserv/netobserv-ebpf-agent:baf9fe0

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=baf9fe0 make set-agent-image

@openshift-ci openshift-ci bot added the lgtm label Feb 2, 2024
@msherif1234
Copy link
Contributor Author

not needed on another run I did confirm the prog isn't loaded I assume I either had incorrect config or ran into other issue

oc exec -i -n default dbgtools-deployment-6bdc7d9bdc-r9nr6 -- bpftool perf show
$ 

@msherif1234 msherif1234 closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants