-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config enable to enable pkt drop in ebpf #258
Conversation
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=459f30c make set-agent-image |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #258 +/- ##
==========================================
- Coverage 33.65% 33.59% -0.06%
==========================================
Files 40 40
Lines 3542 3548 +6
==========================================
Hits 1192 1192
- Misses 2281 2287 +6
Partials 69 69
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @msherif1234 !
/hold |
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
5890a0f
to
07387bf
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=baf9fe0 make set-agent-image |
not needed on another run I did confirm the prog isn't loaded I assume I either had incorrect config or ran into other issue oc exec -i -n default dbgtools-deployment-6bdc7d9bdc-r9nr6 -- bpftool perf show
$ |
Description
its noticed in rhel9.3 the tracepoint and tracing hooks are loaded unconditionally even with the userspace enabling them which is different that rhel9.2
so far all features has enable flags except pktdrop this PR add flag for pkt drop
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.