NETOBSERV-1473: migrating netobserv-agent to TCx for new kernels #262

msherif1234 · 2024-02-04T13:11:30Z

Description

Migrate ebpf agent from TC to TCX "TC eXpress" if the kernel support it, this PR fix #230.

how to check TCX is enabled in ur kernel

zgrep CONFIG_NET_XGRESS /boot/config-$(uname -r)
CONFIG_NET_XGRESS=y

how to check if TCX hooks are attached to all interfaces

sudo bpftool net

xdp:

tc:
wlp0s20f3(2) tcx/ingress tcx_ingress_flow_parse prog_id 3923 link_id 214 
wlp0s20f3(2) tcx/egress tcx_egress_flow_parse prog_id 3922 link_id 213 
br-68b237cee3d3(3) tcx/ingress tcx_ingress_flow_parse prog_id 3923 link_id 216 
br-68b237cee3d3(3) tcx/egress tcx_egress_flow_parse prog_id 3922 link_id 215 
docker0(4) tcx/ingress tcx_ingress_flow_parse prog_id 3923 link_id 218 
docker0(4) tcx/egress tcx_egress_flow_parse prog_id 3922 link_id 217 
enp9s0u2u1u2(1736) tcx/ingress tcx_ingress_flow_parse prog_id 3923 link_id 220 
enp9s0u2u1u2(1736) tcx/egress tcx_egress_flow_parse prog_id 3922 link_id 219 

flow_dissector:

netfilter:

testing

using 6.6.2-201.fc39.x86_64 run standalone agent code as well as e2e test and both passed with the new TCX. Waiting for OCP build with rhel9.4 to be able to resume the testing on OCP cluster
pkt drop
DNS
RTT
SRIOV secondary interface
PCA
performance and scale test
on older kernel we will get this warning and fall back to the legacy TC hooks

time="2024-02-05T12:56:55Z" level=info msg="interface detected. trying to attach TCX hook" component=agent.Flows interface="{1b684d9681b6cb8 106 NS(none)}"
time="2024-02-05T12:56:55Z" level=warning msg="can't attach to TCx hook flow ebpfFetcher. fall back to use legacy TC hook" component=agent.Flows error="failed to attach TCX egress: tcx not supported (requires >= v6.6)" interface="{1b684d9681b6cb8 106 NS(none)}"

Note: GH use ubuntu-latest which is currently 6.2.0 so doesn't have TCX support yet

Dependencies

OCP with rhel9.4 kernel

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

openshift-ci-robot · 2024-02-04T13:11:34Z

codecov · 2024-02-04T13:15:28Z

Codecov Report

Attention: Patch coverage is 1.88679% with 156 lines in your changes are missing coverage. Please review.

Project coverage is 32.96%. Comparing base (08030df) to head (99dc152).

Files	Patch %	Lines
pkg/ebpf/tracer.go	0.00%	133 Missing ⚠️
pkg/agent/packets_agent.go	0.00%	8 Missing ⚠️
pkg/ebpf/bpf_x86_bpfel.go	0.00%	8 Missing ⚠️
pkg/agent/agent.go	12.50%	6 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
- Coverage   34.04%   32.96%   -1.09%     
==========================================
  Files          47       47              
  Lines        3836     3959     +123     
==========================================
- Hits         1306     1305       -1     
- Misses       2444     2568     +124     
  Partials       86       86

Flag	Coverage Δ
unittests	`32.96% <1.88%> (-1.09%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

openshift-ci-robot · 2024-02-04T13:24:06Z

openshift-ci-robot · 2024-02-05T01:46:41Z

@msherif1234: This pull request references NETOBSERV-1408 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

Description

how to check TCX is enabled in ur kernel
zgrep CONFIG_NET_XGRESS /boot/config-$(uname -r)
CONFIG_NET_XGRESS=y
testing
on 6.6.2-201.fc39.x86_64 run standalone agent code as well as e2e test and passed with the new TCX waiting for OCP build with rhel9.4 to be able to resume the testing

test with pkt drop

test with DNS

test with RTT

test SRIOV

performance and scale test

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.

Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).

Does this PR require product documentation?

If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.

Does this PR require a product release notes entry?

If so, fill in "Release Note Text" in the JIRA.

Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.

If so, make sure it is described in the JIRA ticket.

QE requirements (check 1 from the list):

Standard QE validation, with pre-merge tests unless stated otherwise.

Regression tests only (e.g. refactoring with no user-facing change).

No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

msherif1234 · 2024-02-05T12:53:32Z

/ok-to-test

github-actions · 2024-02-05T12:55:16Z

New image:
quay.io/netobserv/netobserv-ebpf-agent:d6040fc

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=d6040fc make set-agent-image

openshift-ci-robot · 2024-02-05T13:17:26Z

@msherif1234: This pull request references NETOBSERV-1408 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

Description

how to check TCX is enabled in ur kernel
zgrep CONFIG_NET_XGRESS /boot/config-$(uname -r)
CONFIG_NET_XGRESS=y
testing
on 6.6.2-201.fc39.x86_64 run standalone agent code as well as e2e test and passed with the new TCX waiting for OCP build with rhel9.4 to be able to resume the testing

test with pkt drop

test with DNS

test with RTT

test SRIOV

test PCA

performance and scale test

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.

Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).

Does this PR require product documentation?

If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.

Does this PR require a product release notes entry?

If so, fill in "Release Note Text" in the JIRA.

Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.

If so, make sure it is described in the JIRA ticket.

QE requirements (check 1 from the list):

Standard QE validation, with pre-merge tests unless stated otherwise.

Regression tests only (e.g. refactoring with no user-facing change).

No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-02-05T13:18:57Z

@msherif1234: This pull request references NETOBSERV-1408 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

Description

how to check TCX is enabled in ur kernel
zgrep CONFIG_NET_XGRESS /boot/config-$(uname -r)
CONFIG_NET_XGRESS=y
testing
on 6.6.2-201.fc39.x86_64 run standalone agent code as well as e2e test and passed with the new TCX waiting for OCP build with rhel9.4 to be able to resume the testing

test with pkt drop

test with DNS

test with RTT

test SRIOV

test PCA

performance and scale test

on older kernel we will get this warning and fall back to the legacy TC hooks
time="2024-02-05T12:56:55Z" level=info msg="interface detected. trying to attach TCX hook" component=agent.Flows interface="{1b684d9681b6cb8 106 NS(none)}"
time="2024-02-05T12:56:55Z" level=warning msg="can't attach to TCx hook flow ebpfFetcher. fall back to use legacy TC hook" component=agent.Flows error="failed to attach TCX egress: tcx not supported (requires >= v6.6)" interface="{1b684d9681b6cb8 106 NS(none)}"
Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.

Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).

Does this PR require product documentation?

If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.

Does this PR require a product release notes entry?

If so, fill in "Release Note Text" in the JIRA.

Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.

If so, make sure it is described in the JIRA ticket.

QE requirements (check 1 from the list):

Standard QE validation, with pre-merge tests unless stated otherwise.

Regression tests only (e.g. refactoring with no user-facing change).

No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-02-05T13:20:10Z

@msherif1234: This pull request references NETOBSERV-1408 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

Description

how to check TCX is enabled in ur kernel
zgrep CONFIG_NET_XGRESS /boot/config-$(uname -r)
CONFIG_NET_XGRESS=y
testing
on 6.6.2-201.fc39.x86_64 run standalone agent code as well as e2e test and passed with the new TCX waiting for OCP build with rhel9.4 to be able to resume the testing

test with pkt drop

test with DNS

test with RTT

test SRIOV

test PCA

performance and scale test

on older kernel we will get this warning and fall back to the legacy TC hooks
time="2024-02-05T12:56:55Z" level=info msg="interface detected. trying to attach TCX hook" component=agent.Flows interface="{1b684d9681b6cb8 106 NS(none)}"
time="2024-02-05T12:56:55Z" level=warning msg="can't attach to TCx hook flow ebpfFetcher. fall back to use legacy TC hook" component=agent.Flows error="failed to attach TCX egress: tcx not supported (requires >= v6.6)" interface="{1b684d9681b6cb8 106 NS(none)}"
fix #230

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.

Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).

Does this PR require product documentation?

If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.

Does this PR require a product release notes entry?

If so, fill in "Release Note Text" in the JIRA.

Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.

If so, make sure it is described in the JIRA ticket.

QE requirements (check 1 from the list):

Standard QE validation, with pre-merge tests unless stated otherwise.

Regression tests only (e.g. refactoring with no user-facing change).

No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-02-05T13:21:31Z

@msherif1234: This pull request references NETOBSERV-1408 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

Description

how to check TCX is enabled in ur kernel
zgrep CONFIG_NET_XGRESS /boot/config-$(uname -r)
CONFIG_NET_XGRESS=y
testing
on 6.6.2-201.fc39.x86_64 run standalone agent code as well as e2e test and passed with the new TCX waiting for OCP build with rhel9.4 to be able to resume the testing

pkt drop

DNS

RTT

SRIOV secondary interface

PCA

performance and scale test

on older kernel we will get this warning and fall back to the legacy TC hooks
time="2024-02-05T12:56:55Z" level=info msg="interface detected. trying to attach TCX hook" component=agent.Flows interface="{1b684d9681b6cb8 106 NS(none)}"
time="2024-02-05T12:56:55Z" level=warning msg="can't attach to TCx hook flow ebpfFetcher. fall back to use legacy TC hook" component=agent.Flows error="failed to attach TCX egress: tcx not supported (requires >= v6.6)" interface="{1b684d9681b6cb8 106 NS(none)}"
fix #230

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.

Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).

Does this PR require product documentation?

If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.

Does this PR require a product release notes entry?

If so, fill in "Release Note Text" in the JIRA.

Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.

If so, make sure it is described in the JIRA ticket.

QE requirements (check 1 from the list):

Standard QE validation, with pre-merge tests unless stated otherwise.

Regression tests only (e.g. refactoring with no user-facing change).

No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-02-05T13:22:44Z

@msherif1234: This pull request references NETOBSERV-1408 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

Description

how to check TCX is enabled in ur kernel
zgrep CONFIG_NET_XGRESS /boot/config-$(uname -r)
CONFIG_NET_XGRESS=y
testing
on 6.6.2-201.fc39.x86_64 run standalone agent code as well as e2e test and passed with the new TCX waiting for OCP build with rhel9.4 to be able to resume the testing

pkt drop

DNS

RTT

SRIOV secondary interface

PCA

performance and scale test

on older kernel we will get this warning and fall back to the legacy TC hooks
time="2024-02-05T12:56:55Z" level=info msg="interface detected. trying to attach TCX hook" component=agent.Flows interface="{1b684d9681b6cb8 106 NS(none)}"
time="2024-02-05T12:56:55Z" level=warning msg="can't attach to TCx hook flow ebpfFetcher. fall back to use legacy TC hook" component=agent.Flows error="failed to attach TCX egress: tcx not supported (requires >= v6.6)" interface="{1b684d9681b6cb8 106 NS(none)}"
fix #230

Dependencies

OCP with rhel9.4 kernel

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.

Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).

Does this PR require product documentation?

If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.

Does this PR require a product release notes entry?

If so, fill in "Release Note Text" in the JIRA.

Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.

If so, make sure it is described in the JIRA ticket.

QE requirements (check 1 from the list):

Standard QE validation, with pre-merge tests unless stated otherwise.

Regression tests only (e.g. refactoring with no user-facing change).

No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-02-05T13:50:17Z

@msherif1234: This pull request references NETOBSERV-1408 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

Description

Migrate ebpf agent from TC hooks to TCX is the kernel support it, this PR fix #230.

how to check TCX is enabled in ur kernel
zgrep CONFIG_NET_XGRESS /boot/config-$(uname -r)
CONFIG_NET_XGRESS=y
testing
on 6.6.2-201.fc39.x86_64 run standalone agent code as well as e2e test and passed with the new TCX waiting for OCP build with rhel9.4 to be able to resume the testing

pkt drop

DNS

RTT

SRIOV secondary interface

PCA

performance and scale test

on older kernel we will get this warning and fall back to the legacy TC hooks
time="2024-02-05T12:56:55Z" level=info msg="interface detected. trying to attach TCX hook" component=agent.Flows interface="{1b684d9681b6cb8 106 NS(none)}"
time="2024-02-05T12:56:55Z" level=warning msg="can't attach to TCx hook flow ebpfFetcher. fall back to use legacy TC hook" component=agent.Flows error="failed to attach TCX egress: tcx not supported (requires >= v6.6)" interface="{1b684d9681b6cb8 106 NS(none)}"
Dependencies

OCP with rhel9.4 kernel

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.

Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).

Does this PR require product documentation?

If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.

Does this PR require a product release notes entry?

If so, fill in "Release Note Text" in the JIRA.

Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.

If so, make sure it is described in the JIRA ticket.

QE requirements (check 1 from the list):

Standard QE validation, with pre-merge tests unless stated otherwise.

Regression tests only (e.g. refactoring with no user-facing change).

No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-02-05T14:23:05Z

@msherif1234: This pull request references NETOBSERV-1408 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

Description

Migrate ebpf agent from TC hooks to TCX is the kernel support it, this PR fix #230.

how to check TCX is enabled in ur kernel
zgrep CONFIG_NET_XGRESS /boot/config-$(uname -r)
CONFIG_NET_XGRESS=y
testing

using 6.6.2-201.fc39.x86_64 run standalone agent code as well as e2e test and both passed with the new TCX. Waiting for OCP build with rhel9.4 to be able to resume the testing on OCP cluster

pkt drop

DNS

RTT

SRIOV secondary interface

PCA

performance and scale test

on older kernel we will get this warning and fall back to the legacy TC hooks
time="2024-02-05T12:56:55Z" level=info msg="interface detected. trying to attach TCX hook" component=agent.Flows interface="{1b684d9681b6cb8 106 NS(none)}"
time="2024-02-05T12:56:55Z" level=warning msg="can't attach to TCx hook flow ebpfFetcher. fall back to use legacy TC hook" component=agent.Flows error="failed to attach TCX egress: tcx not supported (requires >= v6.6)" interface="{1b684d9681b6cb8 106 NS(none)}"
Dependencies

OCP with rhel9.4 kernel

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.

Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).

Does this PR require product documentation?

If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.

Does this PR require a product release notes entry?

If so, fill in "Release Note Text" in the JIRA.

Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.

If so, make sure it is described in the JIRA ticket.

QE requirements (check 1 from the list):

Standard QE validation, with pre-merge tests unless stated otherwise.

Regression tests only (e.g. refactoring with no user-facing change).

No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-02-05T14:24:17Z

@msherif1234: This pull request references NETOBSERV-1408 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

Description

Migrate ebpf agent from TC to TCX "TC eXpress" if the kernel support it, this PR fix #230.

how to check TCX is enabled in ur kernel
zgrep CONFIG_NET_XGRESS /boot/config-$(uname -r)
CONFIG_NET_XGRESS=y
testing

using 6.6.2-201.fc39.x86_64 run standalone agent code as well as e2e test and both passed with the new TCX. Waiting for OCP build with rhel9.4 to be able to resume the testing on OCP cluster

pkt drop

DNS

RTT

SRIOV secondary interface

PCA

performance and scale test

on older kernel we will get this warning and fall back to the legacy TC hooks
time="2024-02-05T12:56:55Z" level=info msg="interface detected. trying to attach TCX hook" component=agent.Flows interface="{1b684d9681b6cb8 106 NS(none)}"
time="2024-02-05T12:56:55Z" level=warning msg="can't attach to TCx hook flow ebpfFetcher. fall back to use legacy TC hook" component=agent.Flows error="failed to attach TCX egress: tcx not supported (requires >= v6.6)" interface="{1b684d9681b6cb8 106 NS(none)}"
Dependencies

OCP with rhel9.4 kernel

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.

Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).

Does this PR require product documentation?

If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.

Does this PR require a product release notes entry?

If so, fill in "Release Note Text" in the JIRA.

Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.

If so, make sure it is described in the JIRA ticket.

QE requirements (check 1 from the list):

Standard QE validation, with pre-merge tests unless stated otherwise.

Regression tests only (e.g. refactoring with no user-facing change).

No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-02-05T14:25:51Z

@msherif1234: This pull request references NETOBSERV-1408 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

Description

Migrate ebpf agent from TC to TCX "TC eXpress" if the kernel support it, this PR fix #230.

how to check TCX is enabled in ur kernel
zgrep CONFIG_NET_XGRESS /boot/config-$(uname -r)
CONFIG_NET_XGRESS=y
how to check if TCX hooks are attached to all interfaces
sudo bpftool net

xdp:

tc:
wlp0s20f3(2) tcx/ingress tcx_ingress_flow_parse prog_id 3923 link_id 214 
wlp0s20f3(2) tcx/egress tcx_egress_flow_parse prog_id 3922 link_id 213 
br-68b237cee3d3(3) tcx/ingress tcx_ingress_flow_parse prog_id 3923 link_id 216 
br-68b237cee3d3(3) tcx/egress tcx_egress_flow_parse prog_id 3922 link_id 215 
docker0(4) tcx/ingress tcx_ingress_flow_parse prog_id 3923 link_id 218 
docker0(4) tcx/egress tcx_egress_flow_parse prog_id 3922 link_id 217 
enp9s0u2u1u2(1736) tcx/ingress tcx_ingress_flow_parse prog_id 3923 link_id 220 
enp9s0u2u1u2(1736) tcx/egress tcx_egress_flow_parse prog_id 3922 link_id 219 

flow_dissector:

netfilter:
testing

using 6.6.2-201.fc39.x86_64 run standalone agent code as well as e2e test and both passed with the new TCX. Waiting for OCP build with rhel9.4 to be able to resume the testing on OCP cluster

pkt drop

DNS

RTT

SRIOV secondary interface

PCA

performance and scale test

on older kernel we will get this warning and fall back to the legacy TC hooks
time="2024-02-05T12:56:55Z" level=info msg="interface detected. trying to attach TCX hook" component=agent.Flows interface="{1b684d9681b6cb8 106 NS(none)}"
time="2024-02-05T12:56:55Z" level=warning msg="can't attach to TCx hook flow ebpfFetcher. fall back to use legacy TC hook" component=agent.Flows error="failed to attach TCX egress: tcx not supported (requires >= v6.6)" interface="{1b684d9681b6cb8 106 NS(none)}"
Dependencies

OCP with rhel9.4 kernel

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.

Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).

Does this PR require product documentation?

If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.

Does this PR require a product release notes entry?

If so, fill in "Release Note Text" in the JIRA.

Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.

If so, make sure it is described in the JIRA ticket.

QE requirements (check 1 from the list):

Standard QE validation, with pre-merge tests unless stated otherwise.

Regression tests only (e.g. refactoring with no user-facing change).

No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-02-05T14:29:19Z

@msherif1234: This pull request references NETOBSERV-1408 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

Description

Migrate ebpf agent from TC to TCX "TC eXpress" if the kernel support it, this PR fix #230.

how to check TCX is enabled in ur kernel
zgrep CONFIG_NET_XGRESS /boot/config-$(uname -r)
CONFIG_NET_XGRESS=y
how to check if TCX hooks are attached to all interfaces
sudo bpftool net

xdp:

tc:
wlp0s20f3(2) tcx/ingress tcx_ingress_flow_parse prog_id 3923 link_id 214 
wlp0s20f3(2) tcx/egress tcx_egress_flow_parse prog_id 3922 link_id 213 
br-68b237cee3d3(3) tcx/ingress tcx_ingress_flow_parse prog_id 3923 link_id 216 
br-68b237cee3d3(3) tcx/egress tcx_egress_flow_parse prog_id 3922 link_id 215 
docker0(4) tcx/ingress tcx_ingress_flow_parse prog_id 3923 link_id 218 
docker0(4) tcx/egress tcx_egress_flow_parse prog_id 3922 link_id 217 
enp9s0u2u1u2(1736) tcx/ingress tcx_ingress_flow_parse prog_id 3923 link_id 220 
enp9s0u2u1u2(1736) tcx/egress tcx_egress_flow_parse prog_id 3922 link_id 219 

flow_dissector:

netfilter:
testing

using 6.6.2-201.fc39.x86_64 run standalone agent code as well as e2e test and both passed with the new TCX. Waiting for OCP build with rhel9.4 to be able to resume the testing on OCP cluster

pkt drop

DNS

RTT

SRIOV secondary interface

PCA

performance and scale test

on older kernel we will get this warning and fall back to the legacy TC hooks
time="2024-02-05T12:56:55Z" level=info msg="interface detected. trying to attach TCX hook" component=agent.Flows interface="{1b684d9681b6cb8 106 NS(none)}"
time="2024-02-05T12:56:55Z" level=warning msg="can't attach to TCx hook flow ebpfFetcher. fall back to use legacy TC hook" component=agent.Flows error="failed to attach TCX egress: tcx not supported (requires >= v6.6)" interface="{1b684d9681b6cb8 106 NS(none)}"
Dependencies

OCP with rhel9.4 kernel

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.

Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).

Does this PR require product documentation?

If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.

Does this PR require a product release notes entry?

If so, fill in "Release Note Text" in the JIRA.

Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.

If so, make sure it is described in the JIRA ticket.

QE requirements (check 1 from the list):

Standard QE validation, with pre-merge tests unless stated otherwise.

Regression tests only (e.g. refactoring with no user-facing change).

No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-02-05T20:42:40Z

@msherif1234: This pull request references NETOBSERV-1408 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

Description

Migrate ebpf agent from TC to TCX "TC eXpress" if the kernel support it, this PR fix #230.

how to check TCX is enabled in ur kernel
zgrep CONFIG_NET_XGRESS /boot/config-$(uname -r)
CONFIG_NET_XGRESS=y
how to check if TCX hooks are attached to all interfaces
sudo bpftool net

xdp:

tc:
wlp0s20f3(2) tcx/ingress tcx_ingress_flow_parse prog_id 3923 link_id 214 
wlp0s20f3(2) tcx/egress tcx_egress_flow_parse prog_id 3922 link_id 213 
br-68b237cee3d3(3) tcx/ingress tcx_ingress_flow_parse prog_id 3923 link_id 216 
br-68b237cee3d3(3) tcx/egress tcx_egress_flow_parse prog_id 3922 link_id 215 
docker0(4) tcx/ingress tcx_ingress_flow_parse prog_id 3923 link_id 218 
docker0(4) tcx/egress tcx_egress_flow_parse prog_id 3922 link_id 217 
enp9s0u2u1u2(1736) tcx/ingress tcx_ingress_flow_parse prog_id 3923 link_id 220 
enp9s0u2u1u2(1736) tcx/egress tcx_egress_flow_parse prog_id 3922 link_id 219 

flow_dissector:

netfilter:
testing

using 6.6.2-201.fc39.x86_64 run standalone agent code as well as e2e test and both passed with the new TCX. Waiting for OCP build with rhel9.4 to be able to resume the testing on OCP cluster

pkt drop

DNS

RTT

SRIOV secondary interface

PCA

performance and scale test

on older kernel we will get this warning and fall back to the legacy TC hooks
time="2024-02-05T12:56:55Z" level=info msg="interface detected. trying to attach TCX hook" component=agent.Flows interface="{1b684d9681b6cb8 106 NS(none)}"
time="2024-02-05T12:56:55Z" level=warning msg="can't attach to TCx hook flow ebpfFetcher. fall back to use legacy TC hook" component=agent.Flows error="failed to attach TCX egress: tcx not supported (requires >= v6.6)" interface="{1b684d9681b6cb8 106 NS(none)}"
Note: GH use ubuntu-latest which is currently 6.2.0 so doesn't have TCX support yet

Dependencies

OCP with rhel9.4 kernel

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.

Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).

Does this PR require product documentation?

If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.

Does this PR require a product release notes entry?

If so, fill in "Release Note Text" in the JIRA.

Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.

If so, make sure it is described in the JIRA ticket.

QE requirements (check 1 from the list):

Standard QE validation, with pre-merge tests unless stated otherwise.

Regression tests only (e.g. refactoring with no user-facing change).

No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

msherif1234 · 2024-04-12T15:16:16Z

/ok-to-test

github-actions · 2024-04-12T15:20:18Z

New image:
quay.io/netobserv/netobserv-ebpf-agent:a8f1bf4

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=a8f1bf4 make set-agent-image

msherif1234 · 2024-04-12T20:03:19Z

/ok-to-test

msherif1234 · 2024-04-12T20:03:45Z

did multiple rebase to keep with latest code, no functional changes

github-actions · 2024-04-12T20:07:26Z

New image:
quay.io/netobserv/netobserv-ebpf-agent:8ce8080

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=8ce8080 make set-agent-image

jotak · 2024-04-16T06:54:47Z

pkg/agent/agent.go

 		alog.WithField("interface", iface).WithError(err).
-			Warn("can't register flow ebpfFetcher. Ignoring")
-		return
+			Warn("can't attach to TCx hook flow ebpfFetcher. fall back to use legacy TC hook")


nit: I would use an Info log rather then Warn as TCx still won't be supported in many configs hence that's still a "normal" behaviour in most cases? (so it doesn't scare the users :-) )

jotak · 2024-04-16T06:55:28Z

pkg/agent/packets_agent.go

 		plog.WithField("[PCA]interface", iface).WithError(err).
-			Warn("can't register packet ebpfFetcher. Ignoring")
-		return
+			Warn("can't attach to TCx hook packet ebpfFetcher. fall back to use legacy TC hook")


jotak · 2024-04-16T07:14:39Z

pkg/ebpf/tracer.go

+			return fmt.Errorf("failed to setns to %s: %w", iface.NetNS, err)
+		}
+	}
+	egrLink, err := link.AttachTCX(link.TCXOptions{


I guess this function should honor the FlowFetcher enableIngress and enableEgress flags, like Register does?

Also that makes me think, as the agent can already be configured to capture only ingress or only egress via config.Direction, the filter config.FlowFilterDirection recently added was probably not necessary? Can we remove it? (not asking that for this PR)

Also that makes me think, as the agent can already be configured to capture only ingress or only egress via config.Direction, the filter config.FlowFilterDirection recently added was probably not necessary? Can we remove it? (not asking that for this PR)

Ok forget about it .. as discussed in slack, these two settings are redundant in ACCEPT filter mode, but they are not in REJECT mode. E.g. we may capture all ingress+egress globally but filter out a small subset of flows that are ingress or egress, for example on a particular port or subnet.

jotak · 2024-04-16T07:20:56Z

pkg/ebpf/tracer.go

@@ -727,6 +797,38 @@ func (p *PacketFetcher) Register(iface ifaces.Interface) error {
 	return p.registerIngress(iface, ipvlan)
 }

+func (p *PacketFetcher) AttachTCX(iface ifaces.Interface) error {


same here, to honor enableIngress/egress

Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>

jotak

code lgtm!

msherif1234 · 2024-04-16T14:33:06Z

/ok-to-test

github-actions · 2024-04-16T14:35:07Z

New image:
quay.io/netobserv/netobserv-ebpf-agent:bc5abad

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=bc5abad make set-agent-image

msherif1234 · 2024-04-17T13:24:46Z

/approve

msherif1234 · 2024-04-17T13:25:40Z

discussed with @Amoghrd and he is fine running QE verification post merge

openshift-ci · 2024-04-17T13:26:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [msherif1234]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added the jira/valid-reference label Feb 4, 2024

openshift-ci bot added the do-not-merge/work-in-progress label Feb 4, 2024

msherif1234 marked this pull request as draft February 4, 2024 13:11

msherif1234 force-pushed the TCx-support branch from a931472 to c649ab6 Compare February 5, 2024 01:42

msherif1234 force-pushed the TCx-support branch 2 times, most recently from 81fe201 to b406e82 Compare February 5, 2024 12:53

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 5, 2024

msherif1234 force-pushed the TCx-support branch from b406e82 to 838a768 Compare February 5, 2024 16:06

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 5, 2024

msherif1234 force-pushed the TCx-support branch 2 times, most recently from 3834684 to 8adf9f7 Compare February 5, 2024 19:27

msherif1234 force-pushed the TCx-support branch from 8adf9f7 to 4c04b7f Compare February 6, 2024 17:07

msherif1234 changed the title ~~WIP: NETOBSERV-1408: migrating netobserv-agent to TCx for new kernels~~ WIP: NETOBSERV-1473: migrating netobserv-agent to TCx for new kernels Feb 8, 2024

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 12, 2024

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 12, 2024

msherif1234 force-pushed the TCx-support branch from ad95e88 to e338a0d Compare April 12, 2024 19:51

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 12, 2024

msherif1234 force-pushed the TCx-support branch from e338a0d to 8e67c8c Compare April 12, 2024 20:02

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 12, 2024

jotak reviewed Apr 16, 2024

View reviewed changes

NETOBSERV-1408: migrating netobserv-agent to TCx for new kernels

b5f42f2

Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>

msherif1234 force-pushed the TCx-support branch from 8e67c8c to b5f42f2 Compare April 16, 2024 11:38

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 16, 2024

msherif1234 requested a review from jotak April 16, 2024 11:39

jotak approved these changes Apr 16, 2024

View reviewed changes

openshift-ci bot assigned jotak Apr 16, 2024

openshift-ci bot added the lgtm label Apr 16, 2024

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 16, 2024

openshift-ci bot added the approved label Apr 17, 2024

openshift-merge-bot bot merged commit e41327e into netobserv:main Apr 17, 2024
10 checks passed

NETOBSERV-1473: migrating netobserv-agent to TCx for new kernels #262

NETOBSERV-1473: migrating netobserv-agent to TCx for new kernels #262

Conversation

msherif1234 commented Feb 4, 2024 • edited

Description

Dependencies

Checklist

openshift-ci-robot commented Feb 4, 2024 • edited by openshift-ci bot

Description

Dependencies

Checklist

codecov bot commented Feb 4, 2024 • edited

Codecov Report

openshift-ci-robot commented Feb 4, 2024 • edited by openshift-ci bot

Description

Dependencies

Checklist

openshift-ci-robot commented Feb 5, 2024 • edited by openshift-ci bot

Description

Dependencies

Checklist

msherif1234 commented Feb 5, 2024

github-actions bot commented Feb 5, 2024

openshift-ci-robot commented Feb 5, 2024 • edited by openshift-ci bot

Description

Dependencies

Checklist

openshift-ci-robot commented Feb 5, 2024 • edited by openshift-ci bot

Description

Dependencies

Checklist

openshift-ci-robot commented Feb 5, 2024 • edited by openshift-ci bot

Description

Dependencies

Checklist

openshift-ci-robot commented Feb 5, 2024 • edited by openshift-ci bot

Description

Dependencies

Checklist

openshift-ci-robot commented Feb 5, 2024 • edited by openshift-ci bot

Description

Dependencies

Checklist

openshift-ci-robot commented Feb 5, 2024 • edited by openshift-ci bot

Description

Dependencies

Checklist

openshift-ci-robot commented Feb 5, 2024 • edited by openshift-ci bot

Description

Dependencies

Checklist

openshift-ci-robot commented Feb 5, 2024 • edited by openshift-ci bot

Description

Dependencies

Checklist

openshift-ci-robot commented Feb 5, 2024 • edited by openshift-ci bot

Description

Dependencies

Checklist

openshift-ci-robot commented Feb 5, 2024 • edited by openshift-ci bot

Description

Dependencies

Checklist

openshift-ci-robot commented Feb 5, 2024 • edited by openshift-ci bot

Description

Dependencies

Checklist

msherif1234 commented Apr 12, 2024

github-actions bot commented Apr 12, 2024

msherif1234 commented Apr 12, 2024

msherif1234 commented Apr 12, 2024 • edited

github-actions bot commented Apr 12, 2024

jotak Apr 16, 2024

Choose a reason for hiding this comment

jotak Apr 16, 2024

Choose a reason for hiding this comment

jotak Apr 16, 2024

Choose a reason for hiding this comment

jotak Apr 16, 2024

Choose a reason for hiding this comment

msherif1234 commented Feb 4, 2024 •

edited

openshift-ci-robot commented Feb 4, 2024 •

edited by openshift-ci bot

codecov bot commented Feb 4, 2024 •

edited

openshift-ci-robot commented Feb 4, 2024 •

edited by openshift-ci bot

openshift-ci-robot commented Feb 5, 2024 •

edited by openshift-ci bot

openshift-ci-robot commented Feb 5, 2024 •

edited by openshift-ci bot

openshift-ci-robot commented Feb 5, 2024 •

edited by openshift-ci bot

openshift-ci-robot commented Feb 5, 2024 •

edited by openshift-ci bot

openshift-ci-robot commented Feb 5, 2024 •

edited by openshift-ci bot

openshift-ci-robot commented Feb 5, 2024 •

edited by openshift-ci bot

openshift-ci-robot commented Feb 5, 2024 •

edited by openshift-ci bot

openshift-ci-robot commented Feb 5, 2024 •

edited by openshift-ci bot

openshift-ci-robot commented Feb 5, 2024 •

edited by openshift-ci bot

openshift-ci-robot commented Feb 5, 2024 •

edited by openshift-ci bot

openshift-ci-robot commented Feb 5, 2024 •

edited by openshift-ci bot

openshift-ci-robot commented Feb 5, 2024 •

edited by openshift-ci bot

msherif1234 commented Apr 12, 2024 •

edited