Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1466 Always send arrays for IfDirections / Interfaces #275

Closed
wants to merge 0 commits into from

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Feb 20, 2024

Description

  • Rename FlowDirections to IfDirections to avoid doing so in FLP reinterpret stage
  • Always send arrays for IfDirections / Interfaces

Dependencies

netobserv/network-observability-operator#578

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.07%. Comparing base (e9d99fc) to head (8d21a91).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
+ Coverage   33.53%   34.07%   +0.53%     
==========================================
  Files          40       40              
  Lines        3554     3569      +15     
==========================================
+ Hits         1192     1216      +24     
+ Misses       2293     2285       -8     
+ Partials       69       68       -1     
Flag Coverage Δ
unittests 34.07% <100.00%> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msherif1234
Copy link
Contributor

/lgtm

@msherif1234
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 21, 2024
@jpinsonneau jpinsonneau changed the title NETOBSERV-1466 append either single or plural fields NETOBSERV-1466 Always send arrays for IfDirections / Interfaces Feb 21, 2024
@jpinsonneau jpinsonneau added the breaking-change This pull request has breaking changes. They should be described in PR description. label Feb 21, 2024
@jpinsonneau jpinsonneau marked this pull request as ready for review February 21, 2024 12:13
@jpinsonneau
Copy link
Contributor Author

Thanks for the quick review @msherif1234

I'm keeping that open until we have all PRs reviewed

@jotak jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 1, 2024
Copy link

github-actions bot commented Mar 1, 2024

New image:
quay.io/netobserv/netobserv-ebpf-agent:c375325

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=c375325 make set-agent-image

@jotak
Copy link
Member

jotak commented Mar 1, 2024

FYI, I've opened a bug related to missed duplicates: https://issues.redhat.com/browse/NETOBSERV-1551 in merge mode
It doesn't seem related to your PR

Copy link

openshift-ci bot commented Mar 12, 2024

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This pull request has breaking changes. They should be described in PR description.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants