-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1466 Always send arrays for IfDirections / Interfaces #275
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #275 +/- ##
==========================================
+ Coverage 33.53% 34.07% +0.53%
==========================================
Files 40 40
Lines 3554 3569 +15
==========================================
+ Hits 1192 1216 +24
+ Misses 2293 2285 -8
+ Partials 69 68 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/lgtm |
/lgtm |
Thanks for the quick review @msherif1234 I'm keeping that open until we have all PRs reviewed |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=c375325 make set-agent-image |
FYI, I've opened a bug related to missed duplicates: https://issues.redhat.com/browse/NETOBSERV-1551 in merge mode |
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
FlowDirections
toIfDirections
to avoid doing so in FLP reinterpret stageIfDirections
/Interfaces
Dependencies
netobserv/network-observability-operator#578
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.