Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1498 add testing to table displays #24

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Apr 9, 2024

Description

Add testing to table displays

  • Flows
  • Packets

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@jpinsonneau jpinsonneau marked this pull request as ready for review April 9, 2024 11:14
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 31.25%. Comparing base (f58b119) to head (8a7ca5f).
Report is 13 commits behind head on main.

Files Patch % Lines
cmd/flow_capture.go 31.57% 11 Missing and 2 partials ⚠️
cmd/packet_capture.go 71.42% 3 Missing and 1 partial ⚠️
cmd/root.go 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            main      #24       +/-   ##
==========================================
+ Coverage   0.00%   31.25%   +31.25%     
==========================================
  Files          5        5               
  Lines        898      944       +46     
==========================================
+ Hits           0      295      +295     
+ Misses       898      629      -269     
- Partials       0       20       +20     
Flag Coverage Δ
unittests 31.25% <55.55%> (+31.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msherif1234
Copy link
Contributor

/lgtm

Copy link

openshift-ci bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2c9fcdb into netobserv:main Apr 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants