Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-844 Unable to have a working statusUrl in FlowCollector with Loki Operator 5.6 #312

Merged
merged 1 commit into from Mar 30, 2023

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Mar 24, 2023

Added status TLS flags for status URL:

  • loki-status-skip-tls Skip TLS checks for loki HTTPS connection
  • loki-status-ca-path Path to loki status CA certificate
  • loki-status-user-cert-path Path to loki status user cert for mTLS
  • loki-status-user-key-path Path to loki status user key for mTLS

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #312 (096cceb) into main (be861fb) will decrease coverage by 0.10%.
The diff coverage is 42.10%.

@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
- Coverage   58.50%   58.41%   -0.10%     
==========================================
  Files         148      148              
  Lines        6541     6565      +24     
  Branches      784      784              
==========================================
+ Hits         3827     3835       +8     
- Misses       2498     2513      +15     
- Partials      216      217       +1     
Flag Coverage Δ
uitests 59.05% <ø> (ø)
unittests 56.59% <42.10%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/plugin-backend.go 0.00% <0.00%> (ø)
pkg/handler/export.go 3.57% <0.00%> (ø)
pkg/handler/resources.go 24.26% <0.00%> (ø)
pkg/httpclient/http_client.go 42.85% <5.00%> (-10.99%) ⬇️
pkg/handler/loki.go 42.02% <37.50%> (-0.12%) ⬇️
pkg/handler/flows.go 65.71% <100.00%> (ø)
pkg/handler/topology.go 54.94% <100.00%> (ø)
pkg/loki/config.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Amoghrd
Copy link
Contributor

Amoghrd commented Mar 27, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 27, 2023
@github-actions
Copy link

New image: ["quay.io/netobserv/network-observability-console-plugin:b4d6563"]. It will expire after two weeks.

@Amoghrd
Copy link
Contributor

Amoghrd commented Mar 28, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Mar 28, 2023
@jotak
Copy link
Member

jotak commented Mar 30, 2023

/lgtm

@jpinsonneau
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Mar 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 644410a into netobserv:main Mar 30, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants