NETOBSERV-1235 NETOBSERV-1241 UI Polishing #374
Conversation
Codecov Report
@@ Coverage Diff @@
## main #374 +/- ##
==========================================
- Coverage 57.67% 57.15% -0.53%
==========================================
Files 166 167 +1
Lines 7712 7783 +71
Branches 935 935
==========================================
Hits 4448 4448
- Misses 2993 3064 +71
Partials 271 271
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/lgtm |
|
/label qe-approved |
jpinsonneau
changed the title
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=e90f2bc make set-plugin-image |
| "Exclude return traffic": "Exclude return traffic", | ||
| "Include return traffic, with swapped source and destination filters": "Include return traffic, with swapped source and destination filters", | ||
| "Switch between one way / back and forth filtering": "Switch between one way / back and forth filtering", | ||
| "One way will only show Source or Destination traffic according to your filters": "One way will only show Source or Destination traffic according to your filters", |
There was a problem hiding this comment.
| "One way will only show Source or Destination traffic according to your filters": "One way will only show Source or Destination traffic according to your filters", | |
| "One way only shows Source or Destination traffic according to your filters": "One way only shows Source or Destination traffic according to your filters", |
There was a problem hiding this comment.
I will follow that conversation instead
https://redhat-internal.slack.com/archives/C02939DP5L5/p1693212771687359?thread_ts=1692819555.340829&cid=C02939DP5L5
There was a problem hiding this comment.
I can still get rid of "will show" 😄
Co-authored-by: Sara Thomas <sarthoma@redhat.com>
github-actions
bot
removed
the
ok-to-test
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpinsonneau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
updated duplicates tooltip
back and forth static tooltip + show only when Src or Dst filter available (as same as swap)
align filter actions on right (avoid them moving when filter change, usefull using swap)
