Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1242 Console plugin build infos #376

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Aug 28, 2023

  • get build version and build date from backend
  • display these
    • in query summary
    • in console as debug

image

image

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch coverage: 72.72% and project coverage change: -0.52% ⚠️

Comparison is base (d0d7fc5) 57.67% compared to head (8501428) 57.15%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #376      +/-   ##
==========================================
- Coverage   57.67%   57.15%   -0.52%     
==========================================
  Files         166      167       +1     
  Lines        7712     7789      +77     
  Branches      935      935              
==========================================
+ Hits         4448     4452       +4     
- Misses       2993     3066      +73     
  Partials      271      271              
Flag Coverage Δ
uitests 58.00% <100.00%> (+0.01%) ⬆️
unittests 54.82% <66.66%> (-1.96%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cmd/plugin-backend.go 0.00% <0.00%> (ø)
pkg/server/server.go 70.00% <ø> (ø)
web/src/model/config.ts 100.00% <ø> (ø)
pkg/handler/frontend-config.go 39.39% <83.33%> (+3.91%) ⬆️
pkg/server/routes.go 89.65% <100.00%> (ø)
web/src/components/query-summary/summary-panel.tsx 46.51% <100.00%> (+0.84%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jotak
Copy link
Member

jotak commented Aug 29, 2023

Would it be ok as well to just write that with console.log ? Just asking because it doesn't seem the best place to put that in the "Query Summary" panel, but on the other hand, it probably doesn't worth it either to create a new "About"-like panel just for that, so I was wondering if console.log would be good enough. Anyway, up to you, I'm also fine if you prefer to keep that as is.

(edit: actually just seeing you also write it via console.debug)

jotak
jotak previously approved these changes Aug 29, 2023
@jpinsonneau
Copy link
Contributor Author

Would it be ok as well to just write that with console.log ? Just asking because it doesn't seem the best place to put that in the "Query Summary" panel, but on the other hand, it probably doesn't worth it either to create a new "About"-like panel just for that, so I was wondering if console.log would be good enough. Anyway, up to you, I'm also fine if you prefer to keep that as is.

I can add an extra section like Version under Configuration or we can rename it to something general like Misc.
WDYT ?

@memodi
Copy link
Contributor

memodi commented Aug 29, 2023

how would the Version show for downstream builds? would it show the iteration for.e.g: 1.4.0-27 ? I am fine having it a way that you have under Configuration. Thanks!

@jpinsonneau
Copy link
Contributor Author

how would the Version show for downstream builds? would it show the iteration for.e.g: 1.4.0-27 ? I am fine having it a way that you have under Configuration. Thanks!

Yes ! That's my expectation. It reuses the tags from the makefile; these are already displayed in pod logs

@jotak
Copy link
Member

jotak commented Aug 31, 2023

I can add an extra section like Version under Configuration or we can rename it to something general like Misc.

Yes +1 for an extra section like "Version"

@openshift-ci
Copy link

openshift-ci bot commented Aug 31, 2023

New changes are detected. LGTM label has been removed.

@jpinsonneau
Copy link
Contributor Author

I can add an extra section like Version under Configuration or we can rename it to something general like Misc.

Yes +1 for an extra section like "Version"

Done:
image
https://github.com/netobserv/network-observability-console-plugin/compare/011be3e64f641727dc9b8a3ca928b9fdd2be8482..8501428163754edf63a63cf2d4b5da3ad314d53c

@memodi
Copy link
Contributor

memodi commented Aug 31, 2023

LGTM, I can verify this post-merge on downstream builds.

@memodi
Copy link
Contributor

memodi commented Aug 31, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Aug 31, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpinsonneau
Copy link
Contributor Author

Thanks guys !

@openshift-merge-robot openshift-merge-robot merged commit 19a7ab9 into netobserv:main Sep 1, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm qe-approved QE has approved this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants