NETOBSERV-1266 Netflow traffic tab crash #377
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
==========================================
- Coverage 57.67% 57.39% -0.28%
==========================================
Files 166 167 +1
Lines 7712 7798 +86
Branches 935 938 +3
==========================================
+ Hits 4448 4476 +28
- Misses 2993 3054 +61
+ Partials 271 268 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
oh didnt see the branch is out of date with master before putting ok-to-test label. If you could rebase with master @jpinsonneau I can go ahead with testing it if its ready |
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=f12ccc4 make set-plugin-image |
github-actions
bot
removed
the
ok-to-test
jpinsonneau
added
the
ok-to-test
Done; it seems the testing is failling so I'll take a look tomorrow about that. |
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=288c675 make set-plugin-image |
github-actions
bot
removed
the
ok-to-test
jpinsonneau
added
the
ok-to-test
|
I'm generating a new image just in case but there are no changes in the behavior if you already started your testing @Amoghrd 👍 |
| switch (id) { | ||
| case 'netflow-traffic-parent': | ||
| case 'pod-tab': |
There was a problem hiding this comment.
what is the rationale for having here only pod/namespace/node and not all the supported kinds? Is it only used in tests?
There was a problem hiding this comment.
yes it's just for local dev purposes and it's hardcoding "test" as name and "default" as namespace
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=f85374c make set-plugin-image |
|
/label qe-approved |
|
New changes are detected. LGTM label has been removed. |
github-actions
bot
removed
the
ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
NetflowTab props is updating a log and retrigger NetflowTraffic page endlessly.
navFuncis loaded whennavigateis called