NETOBSERV-1319 single graph focus

[jpinsonneau]

Description

Focus on a single graph for better display:

Screencast.from.2023-10-06.16-56-35.webm

Dependencies

Based on #389

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[codecov]

Codecov Report

Attention: 211 lines in your changes are missing coverage. Please review.

Comparison is base (6d73e0a) 58.09% compared to head (a4354d4) 57.56%.
Report is 3 commits behind head on main.

Files	Patch %	Lines
cmd/plugin-backend.go	0.00%	54 Missing ⚠️
web/src/utils/columns.ts	19.56%	36 Missing and 1 partial ⚠️
web/src/utils/filter-definitions.ts	72.22%	26 Missing and 4 partials ⚠️
...c/components/netflow-overview/netflow-overview.tsx	68.47%	22 Missing and 7 partials ⚠️
pkg/handler/config.go	61.53%	18 Missing and 2 partials ⚠️
web/src/components/netflow-traffic.tsx	78.12%	3 Missing and 4 partials ⚠️
web/src/model/topology.ts	41.66%	7 Missing ⚠️
web/src/components/metrics/metrics-helper.tsx	37.50%	5 Missing ⚠️
...omponents/metrics/single-metrics-total-content.tsx	0.00%	5 Missing ⚠️
web/src/utils/local-storage-hook.ts	73.33%	3 Missing and 1 partial ⚠️
... and 10 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
- Coverage   58.09%   57.56%   -0.53%     
==========================================
  Files         169      170       +1     
  Lines        7985     8128     +143     
  Branches      990      999       +9     
==========================================
+ Hits         4639     4679      +40     
- Misses       3067     3170     +103     
  Partials      279      279              

Flag	Coverage Δ
uitests	58.75% <68.67%> (+0.13%)	⬆️
unittests	54.27% <31.53%> (-2.30%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Amoghrd]

/ok-to-test

[github-actions]

New image:
quay.io/netobserv/network-observability-console-plugin:4710166

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=4710166 make set-plugin-image

[jpinsonneau]

Rebased with no changes

[github-actions]

New image:
quay.io/netobserv/network-observability-console-plugin:00d68f4

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=00d68f4 make set-plugin-image

[jpinsonneau]

Rebased with no changes

[Amoghrd]

/ok-to-test

[github-actions]

New image:
quay.io/netobserv/network-observability-console-plugin:af20c63

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=af20c63 make set-plugin-image

[jpinsonneau]

As requested in https://issues.redhat.com/browse/NETOBSERV-1319 comments, I've added a tooltip: c58c40a

[Amoghrd]

/ok-to-test

[github-actions]

New image:
quay.io/netobserv/network-observability-console-plugin:2585361

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=2585361 make set-plugin-image

[Amoghrd]

/label qe-approved

[jotak]

I'm seeing small glitches when testing:

1. When viewed on my laptop, the chart overlaps out of the page on the right (my laptop screen resolution is 1920x1080)
2. The scrollbar is located at the right, despite what's actually scrollable is the left pane, which is misleading because when your mouse is over the right pane and you try scrolling down it doesn't actually work, you need to go over the left pane to scroll. idk if it's an issue only in firefox, i didn't test with chrome.

I'm good to merge if you prefer and we add that to a new bug ticket ; because otherwise, LGTM

/lgtm

[jpinsonneau]

1. When viewed on my laptop, the chart overlaps out of the page on the right (my laptop screen resolution is 1920x1080)

I can't reproduce locally, however I pushed a commit to ensure the flex div doesn't wrap content
ea171bd
Does that solve your issue ?

2. The scrollbar is located at the right, despite what's actually scrollable is the left pane, which is misleading because when your mouse is over the right pane and you try scrolling down it doesn't actually work, you need to go over the left pane to scroll. idk if it's an issue only in firefox, i didn't test with chrome.

That's on all browers. I can suggest to switch focused panel on left and list on right as an easy fix 😸 WDYT ?

[github-actions]

New image:
quay.io/netobserv/network-observability-console-plugin:d91d01a

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=d91d01a make set-plugin-image

[github-actions]

New image:
quay.io/netobserv/network-observability-console-plugin:7d21e2f

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=7d21e2f make set-plugin-image

[jotak]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment