NETOBSERV-1316 & NETOBSERV-1380 - Get dns noError codes to always show graphs

[jpinsonneau]

Description

This PR remove the filter on NoError DNS codes on backend side to always return metrics. The filter is done on display side according to the selected options.
It also enable Show NoError kebab options by default to avoid having empty graphs at first display.
Finally, NaN are skipped in stats generation.

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[jpinsonneau]

@Amoghrd I was not able to reproduce the NaN graphs during my tests with main branch. I tried with TCP using the pod provided in NETOBSERV-1245 but it was showing the pie chart correctly.
However I saw it previously so I added some safeguard in the code.

Please let me know if you still see some issues. Thanks !

[codecov]

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (3e9dfcf) 57.92% compared to head (e854027) 57.42%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #422      +/-   ##
==========================================
- Coverage   57.92%   57.42%   -0.50%     
==========================================
  Files         169      170       +1     
  Lines        7947     8015      +68     
  Branches      975      978       +3     
==========================================
  Hits         4603     4603              
- Misses       3070     3139      +69     
+ Partials      274      273       -1     

Flag	Coverage Δ
uitests	58.36% <9.09%> (+0.01%)	⬆️
unittests	54.79% <0.00%> (-1.90%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...c/components/netflow-overview/netflow-overview.tsx	70.00% <ø> (ø)
web/src/utils/columns.ts	66.53% <ø> (ø)
pkg/loki/flow_query.go	68.64% <0.00%> (+0.86%)	⬆️
web/src/components/metrics/latency-donut.tsx	31.03% <0.00%> (-1.11%)	⬇️
...omponents/metrics/single-metrics-total-content.tsx	37.50% <0.00%> (+6.25%)	⬆️
web/src/utils/metrics.ts	87.71% <33.33%> (-0.45%)	⬇️
web/src/components/netflow-traffic.tsx	58.65% <0.00%> (-0.40%)	⬇️
...components/query-summary/metrics-query-summary.tsx	63.63% <7.69%> (+1.87%)	⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jpinsonneau]

Also added DNS Latency & Response Code columns as default here and in the impacted PRs:

• netobserv/network-observability-operator@e125355
• ea7ef39

[Amoghrd]

/ok-to-test

[github-actions]

New image:
quay.io/netobserv/network-observability-console-plugin:ef75123

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=ef75123 make set-plugin-image

[Amoghrd]

/label qe-approved

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment