NETOBSERV-1382 - Custom metrics from config #431
Conversation
jpinsonneau
force-pushed
the
custom_metrics
branch
from
80029a2
to
b7cb684
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
==========================================
- Coverage 57.49% 57.40% -0.09%
==========================================
Files 167 167
Lines 8750 8842 +92
Branches 1131 1160 +29
==========================================
+ Hits 5031 5076 +45
- Misses 3397 3439 +42
- Partials 322 327 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jpinsonneau
changed the title
jpinsonneau
force-pushed
the
custom_metrics
branch
from
b7cb684
to
25faa35
Compare
jpinsonneau
force-pushed
the
custom_metrics
branch
from
25faa35
to
e1633ec
Compare
jpinsonneau
force-pushed
the
custom_metrics
branch
from
e1633ec
to
ce1cb1c
Compare
|
/hold Following netobserv/network-observability-operator#550, this PR will need to be revisited to include |
jpinsonneau
force-pushed
the
custom_metrics
branch
from
ce1cb1c
to
32b366f
Compare
jpinsonneau
force-pushed
the
custom_metrics
branch
from
32b366f
to
07a260f
Compare
jotak
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=7df6957 make set-plugin-image |
|
@jpinsonneau do you think this refactoring will work well when we'll add prometheus as a metrics backend (as per https://issues.redhat.com/browse/NETOBSERV-739) ? |
That should work fine and unlock custom metrics based on available labels in prom |
jpinsonneau
force-pushed
the
custom_metrics
branch
from
07a260f
to
472facc
Compare
|
New changes are detected. LGTM label has been removed. |
github-actions
bot
removed
the
ok-to-test
|
Rebased without code changes |
| # TODO: implement a way to manage plurals for interfaces | ||
| # Interfaces Directions | ||
| #- IfDirections_Bytes | ||
| #- IfDirections_Packets | ||
| #- IfDirections_Flows | ||
| # Interfaces names | ||
| #- Interfaces_Bytes | ||
| #- sum_Interfaces_Bytes | ||
| #- avg_Interfaces_Bytes | ||
| #- Interfaces_Packets | ||
| #- sum_Interfaces_Packets | ||
| #- avg_Interfaces_Packets | ||
| #- Interfaces_Flows |
There was a problem hiding this comment.
Since these fields went plural, this is not working anymore
Loki is supposed to be able to unwarp arrays but it will need some improvments on query side
grafana/loki#4488 (comment)
jpinsonneau
added
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=6176604 make set-plugin-image |
github-actions
bot
removed
the
ok-to-test
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
==========================================
- Coverage 57.49% 57.40% -0.09%
==========================================
Files 167 167
Lines 8750 8842 +92
Branches 1131 1160 +29
==========================================
+ Hits 5031 5076 +45
- Misses 3397 3439 +42
- Partials 322 327 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=2d062c4 make set-plugin-image |
|
/label qe-approved |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
I took the opportunity of NETOBSERV-1382 to allow custom metrics definition in console plugin config from a simple list of ids such as:
The ids are parsed as:
Custom metrics results are saved in a
Map<string, TopologyMetrics[] | GenericMetric[]>Their total are in a similar
Map<string, TopologyMetrics | GenericMetric>Overview panel allow a donut or graph for each of these.
See 25faa35 for change listDependencies
Based on #412
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.