NETOBSERV-121 tab pages

[jpinsonneau]

Add details pages for Pod / Service / Namespace / Deployment

Automatically set filters from selected object infos

[jotak]

Really nice!
I'd put it on hold in order to gather some feedback on the feature, but it's already super interesting as it is.
/hold

[stleerh]

/lgtm

[jotak]

/lgtm
we must create a follow-up task to finish the work once https://issues.redhat.com/browse/NETOBSERV-73 is done

[jotak]

Follow-up created: https://issues.redhat.com/browse/NETOBSERV-156

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from jotak after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jpinsonneau]

Updated from feedbacks :

• filters cannot be updated in tabs, chips show current forced filters
• added 'Edit filter' button to redirect to /netflow-traffic page keeping url arguments (filters / refresh)
• in case of 'No result found', clear all filter button will also redirect to /netflow-traffic removing all arguments

[jpinsonneau]

/retest

[jotak]

looks like filtering by namespace is broken :/ (maybe it's me...)

[jpinsonneau]

looks like filtering by namespace is broken :/ (maybe it's me...)

Hmm good catch ! I also reproduce from main branch.

This seems to be related to type QueryArguments = { [k in AnyQueryArgs]?: unknown }; that produce wrong params key SrcNamespace[] instead of SrcNamespace so everything goes to:

default:
     filterRegexInLine(key, value, &regexStr)

Check #53

[jotak]

/lgtm
(rebased locally & tested)

thanks!

[jotak]

/unhold