Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1435 Duplicate Id fields in Query Summary panel when PacketDrop enabled #441

Merged
merged 1 commit into from Dec 13, 2023

Conversation

jpinsonneau
Copy link
Contributor

Description

Renammed bytes / packets counter ids as follow:

  • bytesCount
  • bytesPerSecondsCount
  • droppedBytesCount
  • droppedBytesPerSecondsCount
  • packetsCount
  • droppedPacketsCount

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1d3b420) 58.60% compared to head (3777f39) 57.84%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #441      +/-   ##
==========================================
- Coverage   58.60%   57.84%   -0.76%     
==========================================
  Files         167      168       +1     
  Lines        8305     8414     +109     
  Branches     1060     1063       +3     
==========================================
  Hits         4867     4867              
- Misses       3126     3234     +108     
- Partials      312      313       +1     
Flag Coverage Δ
uitests 59.15% <ø> (-0.07%) ⬇️
unittests 54.22% <ø> (-2.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Amoghrd
Copy link
Contributor

Amoghrd commented Dec 12, 2023

@jpinsonneau In the code I see only bpsCount renamed to bytesPerSecondsCount; dont see any changes related to droppedCounts, was that missed?

@jpinsonneau
Copy link
Contributor Author

@jpinsonneau In the code I see only bpsCount renamed to bytesPerSecondsCount; dont see any changes related to droppedCounts, was that missed?

There is a switch case on the metrics query summary as following:

id={`${metricType}Count`}

The flow one is not affected here but I renamed bps to bytesPerSeconds for consistency

@Amoghrd
Copy link
Contributor

Amoghrd commented Dec 12, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Dec 12, 2023
Copy link

New image:
quay.io/netobserv/network-observability-console-plugin:d78c780

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=d78c780 make set-plugin-image

@Amoghrd
Copy link
Contributor

Amoghrd commented Dec 12, 2023

/lgtm

@Amoghrd
Copy link
Contributor

Amoghrd commented Dec 12, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Dec 12, 2023
Copy link

openshift-ci bot commented Dec 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6c3c758 into netobserv:main Dec 13, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants