Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-156 tabs initialQueryOptions #81

Closed
wants to merge 1 commit into from

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Feb 22, 2022

This PR sets initial query options for tabs. The user can still update them from the dropdown.

Changes :

  • set destination fields
  • match all / srcOrDst according to each case

Related PR: #83

@openshift-ci
Copy link

openshift-ci bot commented Feb 22, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from jpinsonneau after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak
Copy link
Member

jotak commented Feb 22, 2022

I had to remove some fields not directly related to the selected kind (like pod namespace) when match is 'any' to avoid false positive. We could add them back in the future if we manage more complex AND / OR filtering

hum, that's an issue, actually there can also be false positives if we don't filter on namespace (different pods can have the same name in different namespaces)
and there can also be false positives without doing exact match (cf https://issues.redhat.com/browse/NETOBSERV-176 )

We should certainly prioritize those other tasks

@jpinsonneau
Copy link
Contributor Author

jpinsonneau commented Feb 22, 2022

We should certainly prioritize those other tasks

sure, let's hold

@jpinsonneau
Copy link
Contributor Author

/hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants