New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-135 super columns + NETOBSERV-204 filters #90
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
20c3869
to
e5b0252
Compare
New changes are detected. LGTM label has been removed. |
prefix = "Dst" | ||
} | ||
|
||
for _, value := range values { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be risky to handle so many different cases under the "FQDN" case, no? For instance, what if we're doing a partial matches? could "10.9" be seen as namespace + pod, whereas we're looking for an IP with partial match?
I just wonder if you're not trying to do too much here, beyond the main use case of a FQDN which would just be "namespace.pod" ?
by the way, I think it should be reversed, "pod.namespace" rather than "namespace.pod", it more on page with the actual kube domain naming: https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-s-hostname-and-subdomain-fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes there are a lot of cases but I guess we can improve front end input to split them correctly. As a user I feel it's easier to type namespace first.
What if we separate ip:port
from namespace.pod
cases in two filters and implement autocompletes for namespaces & pods ?
It could show a first AC for namespaces then a second one for pods (filtered by selected namespace).
Then the concatenation will be done by the code and added to filters to avoid mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, if the user is presented specific fields for namespace and pod, it solves the FQDN order problem (but it's more work to do, especially with auto-completion).
+1 also to separate ip/port to a different filter type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I can handle it 👍
Thanks for the feedback
3d2bc90
to
697fa74
Compare
Co-authored-by: Mario Macias <mmaciasl@redhat.com>
697fa74
to
5feff64
Compare
5feff64
to
4010709
Compare
|
I have played a bit around a more generic Kubernetes Object filter for Service / Deployment / StatefulSet / DaemonSet / Job / CronJob. We can either wait for FLP merge or go ahead with it and do the proper modification in processKubeObjectFilter function when FLP is ready |
This PR is an alternative to #83 using FQDN fields
Full Qualified Name fields can either contains
ip:port
ornamespace.pod
Filtering on
SrcFQDN
+DstFQDN
withmatch any
option will group query by (SrcNamespace AND SrcPod) OR (DstNamespace AND DstPod) so it solves NETOBSERV-204Also added the ability to filter on Source / Destination / Both for
Common
fields using an accordion in filter dropdownThese new filters appears in the table as fields for PoC.