Skip to content

Commit

Permalink
rebase fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
jpinsonneau committed Oct 11, 2022
1 parent 0e2da74 commit adc8afe
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion controllers/consoleplugin/consoleplugin_objects.go
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ func buildArgs(desired *flowsv1alpha1.FlowCollectorSpec, ns string) []string {
"-frontend-config", filepath.Join(configPath, configFile),
}

if desiredLoki.ForwardUserToken() {
if desired.Loki.ForwardUserToken() {
args = append(args, "-loki-forward-user-token")
}

Expand Down
3 changes: 3 additions & 0 deletions controllers/consoleplugin/consoleplugin_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -145,16 +145,19 @@ func TestContainerUpdateCheck(t *testing.T) {
corev1.ResourceCPU: resource.MustParse("500m"),
corev1.ResourceMemory: resource.MustParse("500Gi"),
}
spec.ConsolePlugin = containerConfig
assert.True(containerNeedsUpdate(&podSpec, spec, "netobserv"))

//new image
podSpec, containerConfig = getContainerSpecs()
containerConfig.Image = "quay.io/netobserv/network-observability-console-plugin:latest"
spec.ConsolePlugin = containerConfig
assert.Equal(containerNeedsUpdate(&podSpec, spec, "netobserv"), true)

//new pull policy
podSpec, containerConfig = getContainerSpecs()
containerConfig.ImagePullPolicy = string(corev1.PullAlways)
spec.ConsolePlugin = containerConfig
assert.Equal(containerNeedsUpdate(&podSpec, spec, "netobserv"), true)

}
Expand Down

0 comments on commit adc8afe

Please sign in to comment.