NETOBSERV-971 remove omitempty on portNames.enable

This was making it impossible to set it to false, as default is true and
omitempty would remove it after marshaling

api/v1beta1/flowcollector_types.go

@@ -573,7 +573,8 @@ type FlowCollectorConsolePlugin struct {
 type ConsolePluginPortConfig struct {
 	//+kubebuilder:default:=true
 	// enable the console plugin port-to-service name translation
-	Enable bool `json:"enable,omitempty"`
+	// +optional
+	Enable bool `json:"enable"`
 
 	// portNames defines additional port names to use in the console.
 	// Example: portNames: {"3100": "loki"}

controllers/consoleplugin/consoleplugin_test.go

@@ -292,6 +292,33 @@ func TestLabels(t *testing.T) {
 	assert.Empty(svc.Spec.Selector["version"])
 }
 
+func TestFrontendConfigSerDe(t *testing.T) {
+	assert := assert.New(t)
+
+	cfg := flowslatest.FlowCollectorConsolePlugin{
+		PortNaming: flowslatest.ConsolePluginPortConfig{
+			Enable: false,
+			PortNames: map[string]string{
+				"3100": "loki",
+				"8080": "my-service",
+			},
+		},
+	}
+	jmar, err := json.Marshal(cfg)
+	assert.NoError(err)
+	assert.Contains(string(jmar), `"enable":false`)
+	var jfl flowslatest.FlowCollectorConsolePlugin
+	err = json.Unmarshal(jmar, &jfl)
+	assert.NoError(err)
+	assert.False(jfl.PortNaming.Enable)
+
+	loki := flowslatest.FlowCollectorLoki{URL: "http://foo:1234"}
+	spec := flowslatest.FlowCollectorSpec{ConsolePlugin: cfg, Loki: loki}
+	builder := newBuilder(testNamespace, testImage, &spec, &certWatcher)
+	cm, _ := builder.configMap()
+	assert.Contains(cm.Data["config.yaml"], `enable: false`)
+}
+
 func TestAutoScalerUpdateCheck(t *testing.T) {
 	assert := assert.New(t)