Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-691 better document cacheMaxFlows/Timeout (in CRD) #255

Merged
merged 4 commits into from
Jan 30, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Jan 27, 2023

No description provided.

@openshift-ci
Copy link

openshift-ci bot commented Jan 27, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak by writing /assign @jotak in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak
Copy link
Member Author

jotak commented Jan 27, 2023

to be backported in 1.1

@jotak
Copy link
Member Author

jotak commented Jan 27, 2023

@skrthomas we should also update the API reference in the documentation; cf the asciidoc file that I regenerated in this PR

@@ -159,11 +159,11 @@ Type::

| `cacheActiveTimeout`
| `string`
| cacheActiveTimeout is the max period during which the reporter will aggregate flows before sending
| cacheActiveTimeout is the max period during which the reporter will aggregate flows before sending Increasing `cacheMaxFlows` and `cacheActiveTimeout` can decrease the network traffic overhead and the CPU load, however you can expect higher memory consumption and an increased latency in the flow collection.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| cacheActiveTimeout is the max period during which the reporter will aggregate flows before sending Increasing `cacheMaxFlows` and `cacheActiveTimeout` can decrease the network traffic overhead and the CPU load, however you can expect higher memory consumption and an increased latency in the flow collection.
| cacheActiveTimeout is the max period during which the reporter will aggregate flows before sending. Increasing `cacheMaxFlows` and `cacheActiveTimeout` can decrease the network traffic overhead and the CPU load, however you can expect higher memory consumption and an increased latency in the flow collection.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added a period

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx! I need to amend the PR as there are other files to update

@skrthomas
Copy link
Contributor

@jotak I updated the API in the PR I already have open with docs fixes. I hope that's ok.

@openshift-ci openshift-ci bot removed the lgtm label Jan 30, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 30, 2023

New changes are detected. LGTM label has been removed.

@jotak jotak merged commit d57915e into netobserv:main Jan 30, 2023
jotak added a commit to jotak/network-observability-operator that referenced this pull request Jan 31, 2023
…rv#255)

* NETOBSERV-691 better document cacheMaxFlows/Timeout (in CRD)

* Update asciidoc

* Fix missing period

* fix flaky test
jotak added a commit that referenced this pull request Jan 31, 2023
…257)

* NETOBSERV-691 better document cacheMaxFlows/Timeout (in CRD)

* Update asciidoc

* Fix missing period

* fix flaky test
KalmanMeth pushed a commit to KalmanMeth/network-observability-operator that referenced this pull request Feb 13, 2023
* Add conntrack_memory_connections metric

* Add conntrack_input_records operational metric

* Add conntrack_output_records operational metric

* Refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants