Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-773 Copy certificates across namespaces #283

Closed
wants to merge 1 commit into from

Conversation

jotak
Copy link
Member

@jotak jotak commented Mar 1, 2023

Certificates (configmaps or secrets) can now be referred to with their source namespace; when that namespace doesn't match their target namespace (e.g. netobserv or netobserv-privileged), they are copied.

Had to refactor a little bit to break an import cycle between cert watchers and helper

Add tests

TODO

  • make sure Kafka certificates are reloaded in pods, not only for agent also for FLP

Certificates (configmaps or secrets) can now be referred to with their
source namespace; when that namespace doesn't match their target
namespace (e.g. netobserv or netobserv-privileged), they are copied.

Had to refactor a little bit to break an import cycle between cert
watchers and helper

Add tests
@openshift-ci
Copy link

openshift-ci bot commented Mar 1, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jotak
Copy link
Member Author

jotak commented Mar 1, 2023

@jpinsonneau this is what we talked about today on copying certificates. I need to rebase and retest, seems like it's full of conflicts 😬

@jotak
Copy link
Member Author

jotak commented Apr 17, 2023

I'll close and reopen a new one

@jotak jotak closed this Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants