Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push temporary bundle/catalog #293

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Mar 10, 2023

No description provided.

@jotak
Copy link
Member Author

jotak commented Mar 10, 2023

Hey @memodi
The discussion on https://issues.redhat.com/browse/NETOBSERV-872 made me think we can also do something pretty simple like this. We can also generate temporary bundles & catalogs per PR with "ok-to-test"
Here's an example of the comment that is generated: #292 (comment)

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #293 (617f876) into main (8af3676) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #293      +/-   ##
==========================================
+ Coverage   47.53%   47.61%   +0.07%     
==========================================
  Files          43       43              
  Lines        5015     5015              
==========================================
+ Hits         2384     2388       +4     
+ Misses       2419     2416       -3     
+ Partials      212      211       -1     
Flag Coverage Δ
unittests 47.61% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@memodi memodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jotak - this is great and would be very helpful!! thanks.
cc @Amoghrd @nathan-weinberg

@nathan-weinberg
Copy link
Contributor

@memodi perhaps we should update our testing steps to simplify the premerge testing process with this new functionality

@memodi
Copy link
Contributor

memodi commented Mar 10, 2023

@memodi perhaps we should update our testing steps to simplify the premerge testing process with this new functionality

Yes, we should after trying and testing out this method :)

@jotak
Copy link
Member Author

jotak commented Mar 13, 2023

/approve

@memodi @nathan-weinberg @Amoghrd you can start testing as soon as it's merged

@openshift-ci
Copy link

openshift-ci bot commented Mar 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8a4db3c into netobserv:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants