NETOBSERV-956 Allow modifying namespace from web console #301
Conversation
Codecov Report
@@ Coverage Diff @@
## main #301 +/- ##
==========================================
+ Coverage 49.66% 49.67% +0.01%
==========================================
Files 43 43
Lines 5020 5075 +55
==========================================
+ Hits 2493 2521 +28
- Misses 2324 2343 +19
- Partials 203 211 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
msherif1234
changed the title
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New images:
They will expire after two weeks. Catalog source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-2d71da4
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
|
/lgtm cc @OlivierCazade does that work for you too (wrt your PRs) ? |
|
Hi @OlivierCazade is there a way to make sure this all labels we need before this get merged ? |
|
/ok-to-test |
github-actions
bot
removed
the
ok-to-test
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
github-actions
bot
removed
the
ok-to-test
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New images:
They will expire after two weeks. Catalog source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-db95593
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
| @@ -13,7 +13,7 @@ spec: | |||
| scheme: https | |||
| tlsConfig: | |||
| caFile: /etc/prometheus/configmaps/serving-certs-ca-bundle/service-ca.crt | |||
| serverName: netobserv-metrics-service.openshift-operators.svc | |||
| serverName: netobserv-metrics-service.openshift-netobserv-operator.svc | |||
There was a problem hiding this comment.
| serverName: netobserv-metrics-service.openshift-netobserv-operator.svc | |
| serverName: netobserv-metrics-service.netobserv-operator.svc |
Should we use netobserv-operator upstream and openshift-netobserv-operator downstream ?
There was a problem hiding this comment.
We are currently using openshift-operaotors for both so this PR does not change it.
This would force us to maintain a third kind of deployment in the configuration, we already have openshift and kubernetes
| @@ -336,6 +336,8 @@ metadata: | |||
| containerImage: quay.io/netobserv/network-observability-operator:1.0.2 | |||
| createdAt: ':created-at:' | |||
| description: Network flows collector and monitoring solution | |||
| operatorframework.io/cluster-monitoring: "true" | |||
| operatorframework.io/suggested-namespace: openshift-netobserv-operator | |||
There was a problem hiding this comment.
| operatorframework.io/suggested-namespace: openshift-netobserv-operator | |
| operatorframework.io/suggested-namespace: netobserv-operator |
| @@ -9,6 +9,8 @@ metadata: | |||
| containerImage: ':container-image:' | |||
| createdAt: ':created-at:' | |||
| description: Network flows collector and monitoring solution | |||
| operatorframework.io/cluster-monitoring: "true" | |||
| operatorframework.io/suggested-namespace: openshift-netobserv-operator | |||
There was a problem hiding this comment.
| operatorframework.io/suggested-namespace: openshift-netobserv-operator | |
| operatorframework.io/suggested-namespace: netobserv-operator |
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
github-actions
bot
removed
the
ok-to-test
|
https://gitlab.cee.redhat.com/netobserv-midstream/network-observability-operator-cpaas/-/merge_requests/145/diffs will be used to add csv namesspaces annotation for monitoring |
|
/lgtm |
@msherif1234 did the OLM team have any insight as to what we should do wrt taking care of ns deletion? It can be added as an uninstallation step cc @JoeAldinger |
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New images:
They will expire after two weeks. Catalog source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-18ea3a7
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
@skrthomas yes we need to doc deleting NS as part of the uninstall process we discussed this on slack and here is the thread for reference https://redhat-internal.slack.com/archives/C02939DP5L5/p1679502364770879?thread_ts=1678975816.191759&cid=C02939DP5L5 |
|
/label qe-approved |
|
/approve thanks @msherif1234 ! I'll cherry-pick to 1.2 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
jotak
changed the title
|
This PR is being reverted because it was merged early and will go out when the Operator goes out. |
|
@JoeAldinger I'm not sure to get your comment. Are you referring to the related documentation PR, not this very PR? |
Sorry, I was in panic mode last night when I realized I had things merged on the docs side that shouldn't have been and accidentally commented on the wrong PR. PR #57748 is the PR that was reverted. |
No description provided.