Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] NETOBSERV-844 Unable to have a working statusUrl in FlowCollector with Loki Operator 5.6 #309

Merged

Conversation

jpinsonneau
Copy link
Contributor

backport of #307

@jpinsonneau jpinsonneau changed the base branch from main to release-1.2 March 27, 2023 10:38
@jpinsonneau jpinsonneau requested a review from jotak March 27, 2023 10:38
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-1.2@9648908). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release-1.2     #309   +/-   ##
==============================================
  Coverage               ?   50.41%           
==============================================
  Files                  ?       43           
  Lines                  ?     5096           
  Branches               ?        0           
==============================================
  Hits                   ?     2569           
  Misses                 ?     2318           
  Partials               ?      209           
Flag Coverage Δ
unittests 50.41% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jotak
Copy link
Member

jotak commented Mar 30, 2023

/lgtm

@openshift-ci openshift-ci bot removed the lgtm label Mar 30, 2023
@jpinsonneau
Copy link
Contributor Author

/lgtm

Sorry @jotak just noticed this backport was not up to date cb6c6a2

@jotak
Copy link
Member

jotak commented Mar 30, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 30, 2023
@jpinsonneau
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Mar 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ac32da4 into netobserv:release-1.2 Mar 30, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants