NETOBSERV-963, revert most of cert watching [1.2 backport] #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverting most of certificate watching (NETOBSERV-684) as it generates a lot of pods restart. We did not necessarily have to do this certificate watching as CM/secrets are updated within volumes. We might however monitor carefully if new (or old) problems arise, potentially due to the kubelet sync delay for updating volumes And also make sure certificates aren't cached in our different workloads
Codecov Report
@@ Coverage Diff @@
## release-1.2 #315 +/- ##
==============================================
Coverage ? 50.39%
==============================================
Files ? 43
Lines ? 5072
Branches ? 0
==============================================
Hits ? 2556
Misses ? 2311
Partials ? 205
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #312
Reverting most of certificate watching (NETOBSERV-684) as it generates a lot of pods restart.
We did not necessarily have to do this certificate watching as CM/secrets are updated within volumes.
We might however monitor carefully if new (or old) problems arise, potentially due to the kubelet sync delay for updating volumes
And also make sure certificates aren't cached in our different workloads