Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NETOBSERV-933: make sure flows collector CRD has the right namespace for OCP (backport 1.2) #317

Closed
wants to merge 2 commits into from
Closed

NETOBSERV-933: make sure flows collector CRD has the right namespace for OCP (backport 1.2) #317

wants to merge 2 commits into from

Conversation

msherif1234
Copy link
Contributor

Signed-off-by: msherif1234 mmahmoud@redhat.com
(cherry picked from commit 32f7ad3)

@msherif1234 msherif1234 changed the title make sure flows collector CRD has the right namespace for OCP (backport 1.2) NETOBSERV-933: make sure flows collector CRD has the right namespace for OCP (backport 1.2) Mar 31, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 31, 2023 •
edited by openshift-ci bot

@msherif1234: This pull request references NETOBSERV-933 which is a valid jira issue.

In response to this:

Signed-off-by: msherif1234 mmahmoud@redhat.com
(cherry picked from commit 32f7ad3)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msherif1234 msherif1234 changed the base branch from main to release-1.2 March 31, 2023 12:15
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 31, 2023 •
edited by openshift-ci bot

@msherif1234: This pull request references NETOBSERV-933 which is a valid jira issue.

In response to this:

Signed-off-by: msherif1234 mmahmoud@redhat.com
(cherry picked from commit 32f7ad3)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msherif1234
NETOBSERV-904: Make v1beta1 the storage version (netobserv#308)
6a83d01 
* NETOBSERV-904: Make v1beta1 the stored version

Signed-off-by: msherif1234 <mmahmoud@redhat.com>

* use none default value when update flowcollector object to recreate SM

Signed-off-by: msherif1234 <mmahmoud@redhat.com>

---------

Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@msherif1234
make sure flows collector CRD has the right namespace for OCP
7b82d8c 
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
(cherry picked from commit 32f7ad3)
@openshift-ci
Copy link

openshift-ci bot commented Mar 31, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kalmanmeth for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
jira/valid-reference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@msherif1234 @openshift-ci-robot